| Summary: | Cannot find the right lensfun profile for RAW lens correction [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | C. Priisholm <claus.priisholm> |
| Component: | Plugin-Editor-LensCorrection | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version: | 4.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/112108ad8fbcfa61d12dbe678c2f69c70bbd4923 | Version Fixed In: | 4.7.0 |
| Sentry Crash Report: | |||
| Attachments: |
lensfun.patch
attachment-5822-0.html |
||
|
Description
C. Priisholm
2015-01-20 14:20:29 UTC
Maik, If you is interrested by this entry, it's a junior job report... Code relevant in digiKam Lensfun interface is located here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/filters/lens/lensfuniface.cpp#L210 There is a CLI program dedicated to check digiKam LensFun interface with images : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/tests/testlensfuniface.cpp This one will print parser results on the console. Gilles Caulier Claus, We need test images to hack. Please shares files somewhere in a public cloud. Thanks in advance Gilles Caulier Should I attach a zip with a couple images + the xml-file (37MB) or is it better to put it somewhere so you can download it? Buzilla is limited to 1Mb attachement... Ok, I have put the zip file here: http://www.codedroids.dk/pub/digikam-lensfun.zip Let me know if you need anything else. Thanks for the ZIP file. I have created a hack that already works. I can see in the EXIF / Makernote no object distance. You know, in this model the corresponding EXIF / Makernote? Maik Hi Maik Sounds great. I don't have the camera with med so I'll check the meta data stuff next week The files were not taken directly from the memory card but rather after they've been imported by digikam but that should not remove any meta data afaik. Created attachment 90566 [details]
lensfun.patch
The search of camera from metadata is now case insensitive.
A Sony camera model (DSC-RX100) required this already in lensfun-0.2.8.
Manual selection now works, the lenses list was previously not updated after model selection.
Search for camera, model and lens from metadata could fail, because of not blocked signals.
New Sony lenses EXIF tag added to dmetadate.cpp. Object distance will be added when it should exist in the EXIF.
Git commit 112108ad8fbcfa61d12dbe678c2f69c70bbd4923 by Gilles Caulier. Committed on 22/01/2015 at 10:32. Pushed by cgilles into branch 'master'. Apply patch #90566 from Maik Qualmann to make case sensitive search of camera name in metadata for lensfun image editor tool. FIXED-IN: 4.7.0 M +2 -1 NEWS M +16 -1 libs/dimg/filters/lens/lensfuncameraselector.cpp M +1 -0 libs/dimg/filters/lens/lensfuncameraselector.h M +1 -1 libs/dimg/filters/lens/lensfuniface.cpp M +1 -0 libs/dmetadata/dmetadata.cpp http://commits.kde.org/digikam/112108ad8fbcfa61d12dbe678c2f69c70bbd4923 Git commit fbae1beb84e42574571ccca91accd6186fbc02fe by Gilles Caulier. Committed on 22/01/2015 at 11:13. Pushed by cgilles into branch 'frameworks'. backport commit #112108ad8fbcfa61d12dbe678c2f69c70bbd4923 from git/master to frameworks branch M +22 -1 libs/dimg/filters/lens/lensfuncameraselector.cpp M +1 -0 libs/dimg/filters/lens/lensfuncameraselector.h M +2 -2 libs/dimg/filters/lens/lensfuniface.cpp M +4 -2 libs/dmetadata/dmetadata.cpp M +1 -4 libs/dmetadata/dmetadata.h http://commits.kde.org/digikam/fbae1beb84e42574571ccca91accd6186fbc02fe Created attachment 90704 [details] attachment-5822-0.html Hi Maik I've been trying to find object distance (or subject distance) for the Sony alpha 5000 with no luck. My googling turned op a comment in the code for exiv2 but that refers to is as a Minolta something (Sony bought Minolta so that is probably why), but exiv2 cmd line util does not find the info either. I have tested with sonys own playmemories application for windows and that does not show the distance info either. So either they do not record that information, or else it is burried somewhere in the makernote that even sony don't know about :-) This (not entirely new thread, talking about previous generation of alphas) seem to suggest that it is not set (even if subject distance is a part of EXIF): http://www.dyxum.com/dforum/focus-distance-in-exif_topic73942_page2.html Brs Claus PS. great work - seems you spotted another bug related to the lens list not updating - I though that it had to be manually set... 2015-01-20 23:08 GMT+01:00 Maik Qualmann <metzpinguin@gmail.com>: > https://bugs.kde.org/show_bug.cgi?id=343080 > > --- Comment #6 from Maik Qualmann <metzpinguin@gmail.com> --- > Thanks for the ZIP file. I have created a hack that already works. I can > see in > the EXIF / Makernote no object distance. You know, in this model the > corresponding EXIF / Makernote? > > Maik > > -- > You are receiving this mail because: > You reported the bug. > |