Bug 343016

Summary:	org.freedesktop.FileManager1 service should be supported by dolphin
Product:	[Applications] dolphin	Reporter:	Andrey Loskutov <loskutov>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	emmanuelpescosta099, s.suther
Priority:	NOR
Version:	4.14.3
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
URL:	http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
Latest Commit:	http://commits.kde.org/dolphin/7042c6c2899a4e46a095a38ee1481b63ca4b96d8	Version Fixed In:
Sentry Crash Report:

Description Andrey Loskutov 2015-01-18 19:42:52 UTC

It would be nice if dolphin would support http://www.freedesktop.org/wiki/Specifications/file-manager-interface/ for opening folders/selecting files via dbus interface.
For example, firefox and Eclipse are using this.

Reproducible: Always

Steps to Reproduce:
create ~/.local/share/dbus-1/services/org.freedesktop.FileManager1.service

write to the file:
#####
[D-BUS Service]
Name=org.freedesktop.FileManager1
Exec=/usr/bin/dolphin
#####

mkdir ~/test
touch ~/test/hello.txt

dbus-send --print-reply --dest=org.freedesktop.FileManager1 /org/freedesktop/FileManager1 org.freedesktop.FileManager1.ShowItems array:string:"file:/home/USER_NAME/test/hello.txt" string:""

Actual Results:  
First time dolphin can start and shows home directory, next time nothing starts at all. Dbus 

reports after some timeout:
Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.


Expected Results:  
Dolphin starts and selects the given file as if it have been started with --select option. Dbus doesn't complain.

Comment 1 Emmanuel Pescosta 2015-01-18 20:42:35 UTC

I have added a task for this feature on todo.kde.org

Comment 2 Samuel Suther 2015-04-07 16:12:05 UTC

+1 from me!

Comment 3 Ashish Bansal 2015-04-22 13:33:53 UTC

Git commit 7042c6c2899a4e46a095a38ee1481b63ca4b96d8 by Ashish Bansal.
Committed on 22/04/2015 at 13:29.
Pushed by ashishbansal into branch 'master'.

Add dbus interface to dolphin

Implemented org.freedesktop.FileManager1 dbus interface in dolphin
http://www.freedesktop.org/wiki/Specifications/file-manager-interface/

REVIEW: 123313

M  +6    -1    CMakeLists.txt
A  +18   -0    cmake/DbusInterfaceMacros.cmake
A  +3    -0    org.kde.dolphin.FileManager1.service.in
M  +11   -0    src/CMakeLists.txt
A  +64   -0    src/dbusinterface.cpp     [License: GPL (v2+)]
A  +37   -0    src/dbusinterface.h     [License: GPL (v2+)]
A  +35   -0    src/global.cpp     [License: GPL (v2+)]
A  +30   -0    src/global.h     [License: GPL (v2+)]
M  +8    -9    src/main.cpp

http://commits.kde.org/dolphin/7042c6c2899a4e46a095a38ee1481b63ca4b96d8