| Summary: | CANVAS : on working with raw images marked square isn't crop accurate [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Florian Gross <florian> |
| Component: | ImageEditor-Canvas | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version: | 4.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| URL: | http://grossing.org/temp/showfoto.mp4 | ||
| Latest Commit: | http://commits.kde.org/digikam/76657579a2101a0c721544da238a24ec4a195e92 | Version Fixed In: | 4.7.0 |
| Sentry Crash Report: | |||
| Attachments: | originalsize.patch | ||
|
Description
Florian Gross
2015-01-18 19:12:56 UTC
Problably fixed with last 4.6.0 release by Maik Qualmann... Gilles Caulier Florian, RAW or JPEG as no difference with crop tool. Can you try with a JPEG file to see if it's reproducible ? Gilles Caulier I'll try. At the moment i couldn't reproduce the problem wheater with JPEG nor RAW Yes, here is a problem with the (CR2?) RAW images. The first cut after the load is wrong. After undo everything is ok. I think the attribute "originalSize", in this RAW Image not set correctly when loading. Maik After an initial review, I see the bug in libkdcraw. When a RAW image in portrait mode (even with my Nikon NEF) the width and height of the image is reversed in the libkdcraw container. An old Fujifilm RAW has a completely wrong size. I think we will be installing a workaround for now. Maik, The RAW image size is not get from libkdcraw, but from libkexiv2, if i remember. libkdcraw (libraw in fact in background) is used only for RAW files not supported by Exiv2. It's possible that a confusion is done by Exiv2 with TIFF/EP based RAW files. There are a lots of tags dedicated to manage image size. Florian, did you use RawImport tool in editor, or you load RAW file directly as with JPEG ? Gilles Caulier (In reply to Gilles Caulier from comment #6) > Florian, did you use RawImport tool in editor, or you load RAW file directly > as with JPEG ? I copied the RAW files via card reader from a sd card. No import functions were used I talk about RAW Import tool from _Image Editor_. Look in Setup dialog... Gilles Caulier (In reply to Gilles Caulier from comment #8) > I talk about RAW Import tool from _Image Editor_. Look in Setup dialog... Oh sorry. I translate from the german dialog: fast and easy as 8bit. I hope this helps, otherwise i have to look for some pictures with the english dialog flo So, you don't use Import Tool. Try to check if Import tool made a difference here Gilles Caulier The first try: http://grossing.org/temp/IMG_8249_imp1.jpg the second try: http://grossing.org/temp/IMG_8249_imp2.jpg cropped area is much deferred in comparison to the marked area flo the marked areas right end is the right end of the red stripe flo Created attachment 90522 [details]
originalsize.patch
This patch fixes the problem with the RAW files when loading. And I have the IF statements removed from my patch, are not required.
Git commit 76657579a2101a0c721544da238a24ec4a195e92 by Gilles Caulier. Committed on 22/01/2015 at 10:15. Pushed by cgilles into branch 'master'. Apply patch #90522 from MAik Qualmann to fix stored original RAW image size loaded in Image Editor FIXED-IN: 4.7.0 M +2 -1 NEWS M +1 -0 utilities/imageeditor/core/editorcore.cpp M +2 -10 utilities/imageeditor/core/editorcore_p.h http://commits.kde.org/digikam/76657579a2101a0c721544da238a24ec4a195e92 Git commit 3b2a9baaf5afd64a8ac1c45bb9491450df643f11 by Gilles Caulier. Committed on 22/01/2015 at 10:24. Pushed by cgilles into branch 'frameworks'. backport patch #76657579a2101a0c721544da238a24ec4a195e92 from git/master to frameworks branch M +1 -16 utilities/imageeditor/core/editorcore.cpp M +3 -11 utilities/imageeditor/core/editorcore_p.h http://commits.kde.org/digikam/3b2a9baaf5afd64a8ac1c45bb9491450df643f11 |
