Bug 342956

Summary:	Panel icons/text might make sense to go a bit lower
Product:	[Plasma] plasmashell	Reporter:	Albert Astals Cid <aacid>
Component:	Panel	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, notmart
Priority:	NOR	Flags:	bshah: VisualDesign+
Version First Reported In:	5.1.95
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot

Description Albert Astals Cid 2015-01-17 11:07:10 UTC

See the attached screenshot:
 * 3 pixels from top to the "attention line"
 * 2 pixels from the "attention line" to the icon
 * 6 pixels from the icon to the bottom
 * 2 pixels from the "attention line" to the top of the "d"
 * 7 pixels from the bottom of the "g" to the bottom

Feels like the icon text could go at least 1, maybe 2 pixels to the bottom.

Comment 1 Albert Astals Cid 2015-01-17 11:07:23 UTC

Created attachment 90472 [details]
Screenshot

Comment 2 David Edmundson 2015-01-20 10:43:19 UTC

There is a known issue in the sense that we use the same frame margin at the top and the bottom; the top margin has a shadow so visually it's smaller than it really is.

When we used the fixedMargins for sides where we weren't showing a border everything looked too far down, we may need an extra size hint.

Comment 3 Marco Martin 2015-01-20 15:57:47 UTC

tough for the ones in the taskbar, by tweaking the theme it can be adjusted in any way

Comment 4 David Edmundson 2017-03-01 03:07:24 UTC

Themes, especially in the task manager, have been adjusted multiple times since this report was made. Especially 2d1a3364b8c44f4624d7bee18a06a256f967a238. 

Looking at it now, mine differs from the screenshot and looks absolutely spot-on.

I also haven't seen much other feedback on this issue in the past few years.