Summary: | Location runners show results for directories which do not exist | ||
---|---|---|---|
Product: | [Plasma] krunner | Reporter: | cferr <cf> |
Component: | locations | Assignee: | Sebastian Kügler <sebas> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.0 | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/b62fe57e799ec73c622998116a984042a4f8641a | Version Fixed In: | 5.21 |
Description
cferr
2015-01-15 16:01:37 UTC
I agree with not showing the "Go to file://..." if the file doesn't exist. however, the case in-sensitivity was specially designed (and it was hard to get right, and it still doesn't work perfectly), so I'm not too keen on drop that. From what I understand the usability guys seem to think case-insensitivity is a good thing. PS: Please mark version numbers. (In reply to Vishesh Handa from comment #1) > I agree with not showing the "Go to file://..." if the file doesn't exist. > > however, the case in-sensitivity was specially designed (and it was hard to > get right, and it still doesn't work perfectly), so I'm not too keen on drop > that. From what I understand the usability guys seem to think > case-insensitivity is a good thing. > > PS: Please mark version numbers. Sorry for the version number, it is 1.0 (the "About" bow shows "Location, Version 1.0") yet this number is not listed. My version of KDE is 4.13.3, and it doesn't appear as well. Well, if this is a feature rather than a bug, then is it normal to get an "Error" box appear when I'm incorrectly spelling the name and I press Enter, instead of just correcting it for me and opening the directory with Dolphin? Has this feature been designed for use with case-insensitive filesystems only? (In reply to Cocodidou from comment #2) > > Well, if this is a feature rather than a bug, then is it normal to get an > "Error" box appear when I'm incorrectly spelling the name and I press Enter, > instead of just correcting it for me and opening the directory with Dolphin? > Has this feature been designed for use with case-insensitive filesystems > only? With Plasma 5.1, It will automatically choose the right case no matter how you type it. But it still does show "goto file /home/t" even if t doesn't exist. I'm afraid I cannot backport any of these changes to the 4.x series. So the only way you'll get updates is by moving to Plasma 5. I'm changing the version number to 5.x since that way I won't forget about it. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/348 Git commit b62fe57e799ec73c622998116a984042a4f8641a by Alexander Lohnau. Committed on 19/10/2020 at 11:48. Pushed by alex into branch 'master'. Do check if file exists manually FIXED-IN: 5.21 M +4 -2 runners/locations/locationrunner.cpp https://invent.kde.org/plasma/plasma-workspace/commit/b62fe57e799ec73c622998116a984042a4f8641a Git commit d398508a19eda9ad4d5049f3b0fe9259f81263f7 by Alexander Lohnau. Committed on 25/10/2020 at 14:47. Pushed by alex into branch 'master'. Do not set the type to File/Directory if it does not exist This behavior is different from what the docs say and very questionable. M +3 -0 autotests/runnercontexttest.cpp M +14 -100 src/runnercontext.cpp https://invent.kde.org/frameworks/krunner/commit/d398508a19eda9ad4d5049f3b0fe9259f81263f7 |