Summary: | kitemmodels fails to build against QT 5.5 (dev branch) | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kitemmodels | Reporter: | bluescreenavenger |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hrvoje.senjan, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/121562/ | ||
Latest Commit: | http://commits.kde.org/kitemmodels/cab159359a5dcfe281ab11e0410f3daff3b4ac1f | Version Fixed In: | 5.7.0 |
Description
bluescreenavenger
2015-01-15 12:40:51 UTC
I can get it to compile by creating this patch diff --git a/src/kselectionproxymodel.cpp b/src/kselectionproxymodel.cpp index 6774b75..a241728 100644 --- a/src/kselectionproxymodel.cpp +++ b/src/kselectionproxymodel.cpp @@ -1344,7 +1344,7 @@ QModelIndex KSelectionProxyModelPrivate::mapParentFromSource(const QModelIndex & return m_mappedParents.leftToRight(sourceParent); } -#ifndef QT_NO_DEBUG +//#ifndef QT_NO_DEBUG static bool indexIsValid(bool startWithChildTrees, int row, const QList<QPersistentModelIndex> &rootIndexList, const SourceIndexProxyRowMapping &mappedFirstChildren) { if (!startWithChildTrees) { @@ -1365,7 +1365,7 @@ static bool indexIsValid(bool startWithChildTrees, int row, const QList<QPersist } return true; } -#endif +//#endif QModelIndex KSelectionProxyModelPrivate::createTopLevelIndex(int row, int column) const { Git commit cab159359a5dcfe281ab11e0410f3daff3b4ac1f by Hrvoje Senjan. Committed on 17/01/2015 at 20:14. Pushed by hrvojes into branch 'master'. Fix build with Qt 5.5/dev branch in release mode since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its argument for validity" the build shall fail. REVIEW: 121562 FIXED-IN: 5.7.0 M +0 -2 src/kselectionproxymodel.cpp http://commits.kde.org/kitemmodels/cab159359a5dcfe281ab11e0410f3daff3b4ac1f |