Bug 342791

Summary:	Quality sorter does not honor album selection, scans all albums instead
Product:	[Applications] digikam	Reporter:	Johannes Schwenk <johannes.schwenk>
Component:	Maintenance-Quality	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	4.6.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.11.0
Sentry Crash Report:
Attachments:	maintenance.patch

Description Johannes Schwenk 2015-01-13 08:36:58 UTC

The Image Quality Sorter function always scans the whole collection, despite selecting only specific album(s).

Reproducible: Always

Steps to Reproduce:
1. Click on Tools->Maintenance
2. Choose an album
3. Run Image Quality Sorter

Actual Results:  
In the expanded progress bar you can see that other than the selected images are being processed. Also, if debugging output is enabled, you can see all images of the collection being processed.

Expected Results:  
Only the images in the selected album(s) should get processed by the sorter.

Qt: 4.8.6
KDE Development Platform: 4.13.3
digiKam: 4.6.04:

Source of the package: https://launchpad.net/~philip5/+archive/ubuntu/extra/

Comment 1 Maik Qualmann 2015-01-28 21:24:09 UTC

I can not confirm this bug. It scans only images of the selected album.
Note: quality sorter not yet work in digiKam 4.6.0 -> bug 337011

Maik

Comment 2 caulier.gilles 2015-01-28 21:32:38 UTC

Same for me. bug is not reproducible, for all Maintenance tools available.

Gilles Caulier

Comment 3 caulier.gilles 2015-05-10 07:49:05 UTC

Maik,

Can be closed for 4.10.0 ?

Gilles

Comment 4 Maik Qualmann 2015-05-10 09:36:58 UTC

Gilles,

I think yes, quality sorter processes only the selected album.

Maik

Comment 5 Maik Qualmann 2015-05-13 06:15:36 UTC

Created attachment 92575 [details]
maintenance.patch

If tags are selected, the wrong files to be scanned.

Maik

Comment 6 caulier.gilles 2015-05-13 07:49:18 UTC

Comment on attachment 92575 [details]
maintenance.patch

Maik, 

Patch is right. 

Gilles

Comment 7 Maik Qualmann 2015-05-13 10:24:19 UTC

Git commit 191a052f22953ab4d79ac7a240165c8dc0ef5ddf by Maik Qualmann.
Committed on 13/05/2015 at 10:17.
Pushed by mqualmann into branch 'master'.

apply patch #92575 to fix incorrectly selected files, if tags are enabled

M  +10   -1    utilities/maintenance/fingerprintsgenerator.cpp
M  +10   -1    utilities/maintenance/imagequalitysorter.cpp
M  +8    -1    utilities/maintenance/thumbsgenerator.cpp

http://commits.kde.org/digikam/191a052f22953ab4d79ac7a240165c8dc0ef5ddf

Comment 8 caulier.gilles 2015-05-13 11:56:55 UTC

Git commit 21fe385dc8bca637e1fd7a52bf728cbbccb18ec8 by Gilles Caulier.
Committed on 13/05/2015 at 11:56.
Pushed by cgilles into branch 'frameworks'.

backport commit #191a052f22953ab4d79ac7a240165c8dc0ef5ddf from git/master to frameworks branch

M  +10   -1    utilities/maintenance/fingerprintsgenerator.cpp
M  +10   -1    utilities/maintenance/imagequalitysorter.cpp
M  +8    -1    utilities/maintenance/thumbsgenerator.cpp

http://commits.kde.org/digikam/21fe385dc8bca637e1fd7a52bf728cbbccb18ec8