Bug 342747

Summary: Softness parameter doesn't do anything.
Product: [Applications] krita Reporter: wolthera <griffinvalley>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.9 Beta   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/371b6f8f939ac3897aaf8dd904945d7168eaf516 Version Fixed In:
Sentry Crash Report:

Description wolthera 2015-01-11 21:16:13 UTC 
Several things wrong here:

1. The default brush renders as square blocks if softness is on.
2. The sensors attached to this parameter have no effect.

Reproducible: Always
Comment 1 wolthera 2015-01-12 14:23:11 UTC 
Okay, sensors attached to this parameter do have affect, the problem is that the computed info value applied strangely to the base softness. (I think it's multiplied...)

fade=<0.1 = softness is fine.(if inversed, see below)
fade>0.1 = low computed values of softness will result in squares.
As well, somewhere along the line the computed value gets inversed: the default curve gives hard dabs at pressure values, while the opposite is implied by the UI... 

I have looked at kis_brush, kis_dabcache, kis_brushop and kis_softness_pressure_option.
The last one(computed(info) ) is perfectly fine. The others I can't really judge because I don't understand brush dab enough.
Comment 2 wolthera 2015-01-12 14:53:56 UTC 
This only happens in the default brush, I've noticed.

Which means the bug is here:
http://quickgit.kde.org/?p=calligra.git&a=blobdiff&h=9e09e4706738ad4dcb879fbcdf4d2f9d854ef5e3&hp=d670f8a4e4387e1515191e9cc04b65b9d288267b&hb=df2f8e03520860308fb0856208eca00acc3d49f6&f=krita%2Fimage%2Fkis_circle_mask_generator.cpp

And I suspect that the qabs in these

    // we add +1.0 to ensure correct antialising on the border
    qreal nf = norme((qAbs(xr) + 1.0) * d->transformedFadeX,
                     (qAbs(yr) + 1.0) * d->transformedFadeY);
Comment 3 Dmitry Kazakov 2015-01-15 20:44:42 UTC 
Git commit 371b6f8f939ac3897aaf8dd904945d7168eaf516 by Dmitry Kazakov.
Committed on 15/01/2015 at 16:03.
Pushed by dkazakov into branch 'calligra/2.9'.

Fix inverted softness

M  +3    -2    krita/image/kis_circle_mask_generator.cpp
M  +3    -2    krita/image/kis_rect_mask_generator.cpp

http://commits.kde.org/calligra/371b6f8f939ac3897aaf8dd904945d7168eaf516