Bug 342699

Summary: Opacity parameter lock automatically locks flow as well.
Product: [Applications] krita Reporter: wolthera <griffinvalley>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: 2.9 Beta   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: patch to separate flow and opacity some more

Description wolthera 2015-01-10 15:39:12 UTC
This is to be expected after the flow-opacity separation.

Reproducible: Always

Steps to Reproduce:
1. Lock opacity.
2. Switch brush
3. Go back to brush-settings to find flow locked as well.
Comment 1 Halla Rempt 2015-01-29 13:09:11 UTC
Yes, I can confirm.
Comment 2 Halla Rempt 2015-01-29 14:04:14 UTC
Created attachment 90787 [details]
patch to separate flow and opacity some more

Could you check whether this patch breaks flow or opacity? (Or both...)
Comment 3 Halla Rempt 2015-01-29 14:51:07 UTC
Git commit 97271f845320452a0a96da4f1a3cefaaeec6113d by Boudewijn Rempt.
Committed on 29/01/2015 at 14:08.
Pushed by rempt into branch 'calligra/2.9'.

M  +4    -3    krita/plugins/paintops/defaultpaintops/brush/kis_brushop.cpp
M  +1    -1    krita/plugins/paintops/defaultpaintops/brush/kis_brushop.h
M  +7    -20   krita/plugins/paintops/libpaintop/kis_pressure_flow_opacity_option.cpp
M  +3    -6    krita/plugins/paintops/libpaintop/kis_pressure_flow_opacity_option.h
M  +3    -3    krita/plugins/paintops/libpaintop/kis_pressure_flow_opacity_option_widget.cpp
M  +24   -3    krita/plugins/paintops/libpaintop/kis_pressure_flow_option.cpp
M  +11   -2    krita/plugins/paintops/libpaintop/kis_pressure_flow_option.h

http://commits.kde.org/calligra/97271f845320452a0a96da4f1a3cefaaeec6113d
Comment 4 Halla Rempt 2015-02-02 15:07:40 UTC
This broke flow :-(
Comment 5 Halla Rempt 2016-08-23 16:18:00 UTC
Fixed...