| Summary: | should take on accelator of ktouchpadenabler | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Jonathan Riddell <jr> |
| Component: | kcm_touchpad | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | lukas, rajeeshknambiar, simonandric5 |
| Priority: | NOR | Keywords: | release_blocker |
| Version: | 5.17.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kcm-touchpad/91786b418e718639fd044a8f2feae80acd8eb267 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Take over global shortcut keys for touchpad enable/disable/toggle and fix dataengine | ||
|
Description
Jonathan Riddell
2015-01-08 14:42:38 UTC
Created attachment 90361 [details]
Take over global shortcut keys for touchpad enable/disable/toggle and fix dataengine
Here's a patch that takes over global shortcuts for touchpad enable/disable/toggle. It also fixes the applet to use correct plasma components and installing/loading the dataengine.
There's one issue - I couldn't find a replacement to PlasmaCore.ToolTip to port the applet to Plasma2. I couldn't test it either in Fedora 21 as the dataengine doesn't seem to work in my system (not only touchpad dataengine but many others are not working). Please test and check if things work,
FWIW, unwary of this BR, I fixed the above problems today (except the keyboard shortcuts): http://commits.kde.org/kcm-touchpad/7494875a95ccfacc407eb0278f8c1deb71b2b949 @Lukas - thanks, but it breaks the build due to
kcoreaddons_desktop_to_json(plasma_engine_touchpad ${CMAKE_CURRENT_BINARY_DIR}/plasma-dataengine-touchpad.desktop)
Shouldn't that be ${CMAKE_CURRENT_SOURCE_DIR} ?
Nope, the resulting plasma-dataengine-touchpad.desktop is generated at build time using the configure_file() cmake macro Right, that indeed fixes the build issue for me. Thanks! Should this report be closed? Should we remove ktouchpadenabler ? No, the keyboard shortcuts are not incorporated. I saw a commit from Weng Xuetian making certain changes in that area 2 days ago. Guess I'd need to rework this patch, and may post it in reviewboard instead once I find some time. Review Request #122319 created for this. I'd appreciate review. Git commit 91786b418e718639fd044a8f2feae80acd8eb267 by Lukáš Tinkl. Committed on 29/01/2015 at 23:12. Pushed by lukas into branch 'master'. Set global shortcuts for touchpad enable/disable/toggle Patch by: Rajeesh K Nambiar with minor modifications to let it compile :) REVIEW: 122319 M +13 -1 src/kded/kdedactions.cpp http://commits.kde.org/kcm-touchpad/91786b418e718639fd044a8f2feae80acd8eb267 |