Bug 342430

Summary:	When selecting a subset of images instead of all images to download from camera, the numbering of the renamed images adds the number of selected images to the sequence numbers.
Product:	[Applications] digikam	Reporter:	Derrick Rogers <daearogers>
Component:	AdvancedRename-Import	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	4.0.0
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=342996
Latest Commit:		Version Fixed In:	4.7.0
Sentry Crash Report:

Description Derrick Rogers 2015-01-03 01:58:36 UTC

For example:  If I select 30 images to download, the program adds 30 to the sequence number of the renamed image even though I defined the renaming to include sequence numbers starting with 1.  The first image file name will include sequence number 31 instead of 1.  When I download all images from the camera, the sequence numbers are correct and start with 1.

Reproducible: Always

Steps to Reproduce:
1.  Click on Import -> Cameras and select attached camera from list.
2.  Choose custom renaming with number option starting with 1.
3.  Select set of images to download.
4.  Count number of images selected.
5.  Click on Download -> Download Selected
6.  Select directory and click OK

Actual Results:  
After download complete, look at sequence number in filenames.  The sequence number includes an offset of the number of images selected. 

Expected Results:  
I defined the numbering to start with 1, so I expect the sequence numbers to start with 1 instead of 1+# of images selected.

Running Kubuntu 14.04 LTS 32 bit.

Comment 1 caulier.gilles 2015-01-25 11:43:08 UTC

Git commit 7f3459d55dd453f257ece35398175bba22ea4109 by Gilles Caulier.
Committed on 25/01/2015 at 11:39.
Pushed by cgilles into branch 'master'.

Apply patch #90637 from Maik Qualmann to fix image renaming settings rules in Import Tool to work properly while downloading.
Related: bug 342996, bug 314441, bug 329438, bug 307253
FIXED-IN: 4.7.0

M  +3    -1    NEWS
M  +2    -2    utilities/importui/backend/cameracontroller.cpp
M  +67   -44   utilities/importui/main/importui.cpp
M  +1    -0    utilities/importui/main/importui.h
M  +5    -0    utilities/importui/views/importview.cpp
M  +1    -0    utilities/importui/views/importview.h

http://commits.kde.org/digikam/7f3459d55dd453f257ece35398175bba22ea4109

Comment 2 caulier.gilles 2015-01-25 14:01:07 UTC

Git commit 0201e6fc8549ac849029daf36eaeadd6ebb4d4ae by Gilles Caulier.
Committed on 25/01/2015 at 13:58.
Pushed by cgilles into branch 'frameworks'.

Backport commit #7f3459d55dd453f257ece35398175bba22ea4109 from git/master to frameworks branch.
Related: bug 342996, bug 314441, bug 329438, bug 307253

M  +3    -3    utilities/importui/backend/cameracontroller.cpp
M  +74   -50   utilities/importui/main/importui.cpp
M  +1    -0    utilities/importui/main/importui.h
M  +5    -0    utilities/importui/views/importview.cpp
M  +1    -0    utilities/importui/views/importview.h

http://commits.kde.org/digikam/0201e6fc8549ac849029daf36eaeadd6ebb4d4ae

Comment 3 Maik Qualmann 2015-01-25 16:46:36 UTC

This bug can be closed. The numbering is only for selected images or all images, when no selected.