Bug 342393

Summary:	Game state not reset when changing board layout
Product:	[Applications] kmahjongg	Reporter:	Jan-Peter Nilsson <kdebugs>
Component:	general	Assignee:	Unassigned bugs mailing-list <unassigned-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jwrigley7, kde-games-bugs, schwarzer
Priority:	NOR
Version:	0.8
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Jan-Peter Nilsson 2015-01-01 17:41:44 UTC

Changing the board layout will create a new game using the new layout but will not reset the game state.

Reproducible: Always

Steps to Reproduce:
1. Complete a game
2. Wait for the replay animation to finish (probably not required)
3. Go to settings and change the board layout

Actual Results:  
A new game is created using the new layout but the game state is not reset, the game is still marked as finished so pause/save/undo/redo is not available.

Expected Results:  
The game state should be reset when a new game is created.

Comment 1 James W 2015-01-02 01:12:18 UTC

Hi there,
I can confirm this on KDE 4.14.3 with KMahjongg .8. Perhaps this and bug 342160 are related?

(note: I'm a Google Code-in student)

Comment 2 Jan-Peter Nilsson 2015-01-02 13:55:42 UTC

Hi

Not really, with bug 342160 it is just about the menu, it needs an update to reflect the game state.
Here it is about the actual game state, triggering and update ot the menu will not help.

When finishing a game mFinished is set to true, (re)starting a game from the GUI it will be reset but when a new game is triggered from inside the board widget by the configuration change it is not reset.

Comment 3 Frederik Schwarzer 2016-01-05 01:18:32 UTC

I cannot reproduce this on current master.

Please check master version and repoen this in case you think it's not fixed properly.