Summary: | Two bars in notifications when move/copy files | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Gustavo Alvarez <sl1pkn07> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bhush94, faure, kde, kdelibs-bugs, mklapetek, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kio/0314906ed66fb37dc7cd12974a18de58ee608ac2 | Version Fixed In: | 5.7 |
Description
Gustavo Alvarez
2014-12-28 13:00:40 UTC
I think this is generic bug in either KIO or dolphin.. as this seems to happen even with plasmashell not running. CCing dfaure Re-assigning to KIO since this happens even without plasma running (ie. you get two legacy copy dialogs too) David, could you please share some insights on where to look in kio to fix this? I'd like to look into this. I think this is due to the new DropJob, which doesn't set HideProgressInfo on itself nor on its KIO::copy subjob --> two progress infos. Since the progress comes from the copyjob, I guess it should set HideProgressInfo on itself. Ah but I thought this was taken care of by the fact that it doesn't call registerJob in DropJobPrivate::newJob (see the comment there). Well, it's something to do with that. I guess the DropJob is getting progress info somehow, especially if this didn't happen before KF5.6. Does DropJob get executed also on non-dnd operations? As this also happens when you just ctrl+c ctrl+v a file in Dolphin, no drag&drop involved. Oh interesting, I've put a qdebug in the job tracker interface and this came up: dolphin(8873) KJobTrackerInterface::registerJob: ---> Registering job KIO::PasteJob(0x1f365b0) dolphin(8873) KJobTrackerInterface::registerJob: ---> Registering job KIO::CopyJob(0x1e6ee20) So I guess it's the PasteJob not hiding the progress info. I'll have a look there. Git commit 0314906ed66fb37dc7cd12974a18de58ee608ac2 by Martin Klapetek. Committed on 23/01/2015 at 22:34. Pushed by mklapetek into branch 'master'. Don't show two progress dialogs for PasteJob PasteJob creates a copy/move job and passes its flags to it. These jobs then register with the progress dialog, so no need for the PasteJob to register for progress tracking too. CHANGELOG: Fix two progress bars/dialogs appearing for copy/move jobs REVIEW: 122220 FIXED-IN: 5.7 M +2 -3 src/widgets/pastejob_p.h http://commits.kde.org/kio/0314906ed66fb37dc7cd12974a18de58ee608ac2 |