Bug 342258

Summary:	Launch speed limited by bookmarks.xml, not the docdata XMLs
Product:	[Applications] okular	Reporter:	Alan Aversa <aversa>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	REPORTED ---
Severity:	minor	CC:	aacid, justin.zobel
Priority:	NOR
Version First Reported In:	0.20.3
Target Milestone:	---
Platform:	unspecified
OS:	Linux
URL:	https://forum.kde.org/viewtopic.php?f=251&t=124136&p=326239#p326239
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alan Aversa 2014-12-27 20:41:04 UTC

Okular's launch speed is severely limited by "bookmarks.xml" (which is only about 400 KB on my machine), not by my thousands of docdata files!

My ~400 KB bookmarks.xml slows Okular launch speeds down considerably.

Reproducible: Always

Steps to Reproduce:
Here's some timing information on Okular launches on my Intel core i3 laptop with a ~400 KB bookmarks.xml file:

real    0m5.148s
user    0m4.702s
sys     0m0.090s

My ~/.kde/share/apps/okular/ folder is even running on a fast RAM disk.


Expected Results:  
Deleting bookmarks.xml speeds up Okular launching considerably:

real    0m1.323s
user    0m0.749s
sys     0m0.066s

Feature request: Why doesn't Okular just store bookmarks in the particular documents' docdata XML files, that way the entire bookmarks.xml doesn't have to be scanned every time Okular launches?

Comment 1 Albert Astals Cid 2014-12-29 21:52:40 UTC

Ouch you have a 400kb bookmarks file? Just out of curiosity how many bookmarks do you have?

Comment 2 Alan Aversa 2014-12-31 02:42:35 UTC

(In reply to Albert Astals Cid from comment #1)
> Ouch you have a 400kb bookmarks file? Just out of curiosity how many
> bookmarks do you have?
668

Comment 3 Albert Astals Cid 2015-01-01 19:15:00 UTC

Ok, i'll see what i can do, need to create that many bookmarks first. Thanks for the report :)

Comment 4 Justin Zobel 2020-11-08 01:12:14 UTC

(In reply to Albert Astals Cid from comment #3)
> Ok, i'll see what i can do, need to create that many bookmarks first. Thanks
> for the report :)

Hey Albert, were you able to recreate this issue with large bookmark files?

Comment 5 Albert Astals Cid 2020-11-08 10:29:56 UTC

I don't remember, but since i never came back to this, i either was not or i got sidetracked by other stuff.

Someone needs to check.