Bug 342184

Summary: Double "Select All" shortcut entry in "Menu > Settings > Configure Shortcuts"
Product: [Applications] krita Reporter: mvowada <freebox64>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/c02946c86c44a86a912b5c2100db8eaec5d92209 Version Fixed In:
Sentry Crash Report:

Description mvowada 2014-12-24 09:12:28 UTC 
In "Menu > Settings > Configure Shortcuts" two shortcut keys for the "Select All" entry, are exposed. Both are set as "Default: CTRL+A".

Could be that I'm overlooking what is the purpose of each one, though.

Reproducible: Always

Steps to Reproduce:
1. Menu > Settings > Configure Shortcuts
2. Type "select all" in the "Search" field

Actual Results:  
Will pop out two identical entries for the shortcut keys "Select All".

Expected Results:  
A unique shortcut key for "Select All" would be desirable.
Comment 1 mvowada 2014-12-24 09:16:39 UTC 
Forgot to mention I tested with: Krita 2+git20141221+r73452-51-dk
Comment 2 Halla Rempt 2014-12-24 09:35:57 UTC 
One probably comes from the text tool, the other from Krita itself.
Comment 3 mvowada 2014-12-24 10:16:59 UTC 
Thank you, it makes sense. Would help to not confusing them, something like: 

- Select All Text
- Select All
Comment 4 Halla Rempt 2015-01-03 13:57:27 UTC 
Git commit c02946c86c44a86a912b5c2100db8eaec5d92209 by Boudewijn Rempt.
Committed on 03/01/2015 at 11:06.
Pushed by rempt into branch 'calligra/2.9'.

Create a master action collection for the shortcut editor

This is still a half-way solution, ideally we'd just create actions from
the .action file and fetch those actions in the code where we need an
action, so there's still duplication. If we make the master action
collection the source for new actions, we will also have to make the
krita.action file translatable.

If you create an action which should have an editable shortcut, you need
to add that to a .action file. Make sure that all the text is exactly the
same, so it gets translated in the shortcut dialog.

On closing the shortcut dialog, changed shortcuts are saved. All
mainwindows's actioncollection will re-read the configuration so they
are synchronized. There's no local krita.rc file anymore, so the windows
won't be able to save the shortcuts to the local krita.rc, all shorcuts
are saved in the kritarc config file.
Related: bug 313218, bug 342270, bug 337368

A  +336  -0    krita/krita.actions
M  +1    -14   krita/ui/KisMainWindow.cpp
M  +92   -3    krita/ui/KisPart.cpp
M  +19   -0    krita/ui/KisPart.h
M  +0    -23   krita/ui/KisView.cpp
M  +0    -22   krita/ui/KisViewManager.cpp

http://commits.kde.org/calligra/c02946c86c44a86a912b5c2100db8eaec5d92209