Bug 342165

Summary:	Demo leaves redoable moves in new game
Product:	[Applications] kmahjongg	Reporter:	Jan-Peter Nilsson <kdebugs>
Component:	general	Assignee:	Unassigned bugs mailing-list <unassigned-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-games-bugs, schwarzer
Priority:	NOR
Version:	0.8
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Initialize GameData allow_undo and allow_redo from constructor

Description Jan-Peter Nilsson 2014-12-23 17:00:09 UTC

Aborting a demo by clicking on the game board creates a new game but does not set the redo state, which makes redo available even though there is nothing to redo.

Clicking redo at this point does not appear to do anything except updating the removed tiles counter and making undo available, clicking undo will create an empty tile on the top left corner of the game board.

Reproducible: Always

Steps to Reproduce:
1. Select Demo in the Move menu
2. Click anywhere on the game board to abort the demo

Actual Results:  
A new game is created with undo available.

Expected Results:  
Undo should not be available until after the first move

Comment 1 Jan-Peter Nilsson 2014-12-23 23:42:56 UTC

Created attachment 90105 [details]
Initialize GameData allow_undo and allow_redo from constructor

The problem is that allow_redo (and allow_undo and) are not initialized by the GameData constructor, so if we create a new instance without setting it we don't know what we will get.

Comment 2 Frederik Schwarzer 2016-01-04 00:46:38 UTC

This appeasr to be fixed in current master branch.

Please test the master version and ropen this in case it is not fixed properly.