Summary: | Export filters should warn if the image contains unsupported features. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Sven Langkamp <sven.langkamp> |
Component: | File formats | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dimula73, halla, pcchou, tysontanx |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Sven Langkamp
2014-12-22 22:29:44 UTC
I'm not sure that automatic conversion is desirable, though. And are you sure tiff supports 16f? As for photoshop, at least the documentation I have only says it's got 16 bit integer: http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577409_19840 "Depth: the number of bits per channel. Supported values are 1, 8, 16 and 32." I think it should convert, but warn. Tiff has 32 bit float, although it's not that important anymore. Photoshop has 32bit float so it should fall back to that. Btw saving 32bit to psd also doesn't work. I'm a google code-in who is trying to do bug triaging task. Can you provide which version of krita are you using? Also, can you give more description about how it "refuse to save"? Git commit a10298726b78b5e57a4642754ab4b1e66a127ed3 by Dmitry Kazakov. Committed on 29/12/2014 at 13:04. Pushed by dkazakov into branch 'calligra/2.9'. Fix saving of RGBF16/F32 images into TIFF Also add a unittest for that M +1 -1 krita/plugins/formats/tiff/kis_tiff_writer_visitor.cpp M +44 -0 krita/plugins/formats/tiff/tests/kis_tiff_test.cpp M +1 -0 krita/plugins/formats/tiff/tests/kis_tiff_test.h http://commits.kde.org/calligra/a10298726b78b5e57a4642754ab4b1e66a127ed3 A final summary of the bug: 1) [DONE] Tiff now can save F16/F32 images nicely 2) [WONTFIX or LATER] PSD support of F32 is not documented so we cannot implement it 3) [TODO] PNG, JPEG, BMP and other trivial formats should still save F16/F32 images with conversion into U8/U16 on the fly. Of course the user should be notices about the fact of conversion. We even has two warnings now! We should fix the warning on file format incompatibilities. *** Bug 344810 has been marked as a duplicate of this bug. *** This is now implemented in the rempt/impex refactoring branch. Thank you, Boud! Hope we can soon see this fix at work. Additonally, today I just received another question about wrong color output because people are using sRGB-elle-v2-srgbtrc.icc with 16 bit while exporting it as PNG. They do that all the time because we tell them 16 bit is superior. Can we just automatically convert the color space to sRGB 8bit for them while exporting as JPG/PNG? Or, do we consider collapsing those color space options by default in Document Creation dialogue? |