Bug 341821

Summary: "Cancel" button in Import window does nothing [patch]
Product: [Applications] digikam Reporter: Victor Engmark <kde.org>
Component: Import-Gphoto2Assignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 4.5.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/97e4b914080ddc03a1460e4cbc586c092d290792 Version Fixed/Implemented In: 4.7.0
Sentry Crash Report:
Attachments: importcancel.patch

Description Victor Engmark 2014-12-12 18:52:39 UTC 
See summary.

Reproducible: Always

Steps to Reproduce:
1. Connect a camera
2. Click "Import" and select the camera
3. Click "Cancel" in the new window

Actual Results:  
Nothing happens

Expected Results:  
The window should close. Alternatively, if this button is only to cancel an *ongoing* import, it should be disabled while no import is in progress.
Comment 1 caulier.gilles 2014-12-12 19:45:45 UTC 
Which king of camera you use while downloading ?

Gilles Caulier
Comment 2 Victor Engmark 2014-12-12 23:14:28 UTC 
Canon 7D
Comment 3 caulier.gilles 2014-12-13 08:02:57 UTC 
So, it's a Gphoto2 driver camera...
Comment 4 Maik Qualmann 2015-01-19 20:46:20 UTC 
Created attachment 90525 [details]
importcancel.patch

This patch restore the function of the cancel button.
Comment 5 caulier.gilles 2015-01-21 20:09:48 UTC 
Git commit 97e4b914080ddc03a1460e4cbc586c092d290792 by Gilles Caulier.
Committed on 21/01/2015 at 20:07.
Pushed by cgilles into branch 'master'.

Apply patch #90525 from Maik Qualmann to restore cancel button functionality in import tool while files processing from camera.
FIXED-IN: 4.7.0

M  +2    -1    NEWS
M  +1    -1    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/97e4b914080ddc03a1460e4cbc586c092d290792
Comment 6 caulier.gilles 2015-01-21 20:15:56 UTC 
Git commit 848304af7ee15027d02ec2138212d8d011803466 by Gilles Caulier.
Committed on 21/01/2015 at 20:14.
Pushed by cgilles into branch 'frameworks'.

backport commit #97e4b914080ddc03a1460e4cbc586c092d290792 from git/master to frameworks branch

M  +2    -2    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/848304af7ee15027d02ec2138212d8d011803466