| Summary: | Konsole crash immediately when launched or new tab created | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Takahiro Hashimoto <kenya888> |
| Component: | general | Assignee: | Konsole Bugs <konsole-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | Keywords: | drkonqi |
| Priority: | NOR | ||
| Version First Reported In: | 3.90.900 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konsole/7986af1d253c409e34b2d7aeae7032fdaccb64e5 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | fix the line property to 0(LINE_DEFAULT) | ||
|
Description
Takahiro Hashimoto
2014-12-12 09:21:36 UTC
I have investigated this issue and found out PlainTextDecoder::decodeLine() failed in TerminalDisplay.cpp:2830
------
case Qt::ImSurroundingText: {
// return the text from the current line
QString lineText;
QTextStream stream(&lineText);
PlainTextDecoder decoder;
decoder.begin(&stream);
decoder.decodeLine(&_image[loc(0, cursorPos.y())], _usedColumns, _lineProperties[cursorPos.y()]);
decoder.end();
return lineText;
}
-------
As I use qimsys, a Japanese input method written in Qt, TerminalDisplay::inputMethodQuery is called by event.
I checked PlainTextDecoder::decodeLine() implements. I think it need not care if line property is LINE_DEFAULT of LINE_WRAPPED when launching konsole at present. I suggest a patch to fix LineProperty to 0(LINE_DEFAULT) in inputMethodQuery.
Created attachment 91230 [details]
fix the line property to 0(LINE_DEFAULT)
Git commit 7986af1d253c409e34b2d7aeae7032fdaccb64e5 by Kurt Hindenburg. Committed on 28/02/2015 at 15:39. Pushed by hindenburg into branch 'master'. Prevent crashes upon startup and/or new tab when using input methods TerminalDisplay::inputMethodQuery causes crashes when using non-standard input methods. Qt::ImSurroundingText was trying to use lineProperties of the current line, but this parameter is ignored in decodeLine anyway. Thanks to Takahiro Hashimoto kenya888 gmail com for report, research and patch M +1 -1 src/TerminalDisplay.cpp http://commits.kde.org/konsole/7986af1d253c409e34b2d7aeae7032fdaccb64e5 |