Bug 341758

Summary: BQM Watermark tool : Option to set size based on given dimension
Product: [Applications] digikam Reporter: DrSlony <bugs>
Component: Plugin-Bqm-WaterMarkAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: ahmed.fathi.abdelmageed, bugs, caulier.gilles
Priority: NOR    
Version: 4.12.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/digikam/5ec20e2073752679a3acb760c63cc7f5577b9bc5 Version Fixed In: 5.5.0
Sentry Crash Report:
Attachments: patch to fix the watermark size
Pictures Before And After tha patch
Modify the previous watermarkSize patch for mistake

Description DrSlony 2014-12-10 20:11:15 UTC 
The watermark tool in the BQM can be scaled using only one "Size" slider. Apply it to portrait and landscape photos and you end up with a very differing watermark size.
This is a feature request to let the user configure which dimension the watermark size should be scaled by - width, height, or diagonal (I guess now it uses the diagonal?).

Reproducible: Always
Comment 1 DrSlony 2015-08-13 08:59:37 UTC 
I think currently it uses the width, always, which is why it doesn't work well when you process both portrait and landscape photos. It could work better with diagonal. Or even better, in pixels instead of %.
Comment 2 Ahmed Fathi 2017-01-19 13:10:50 UTC 
Created attachment 103530 [details]
patch to fix the watermark size

I think this is highly related to this issue here 

http://digikam.1695700.n4.nabble.com/Inconsistent-watermark-sizes-depending-on-pictures-ratio-td4692920.html

I made a patch for minor modification.My patch doesn't allow the user to choose height or width , but it simply checks the ratio between height and width . if the height is much larger , it will modify the watermark size accordingly 

It produced much better results . The patch is attached
Comment 3 Ahmed Fathi 2017-01-19 13:28:16 UTC 
Created attachment 103533 [details]
Pictures Before And After tha patch

These photos show the result before and after the patch
Comment 4 Ahmed Fathi 2017-01-19 14:28:44 UTC 
Created attachment 103536 [details]
Modify the previous watermarkSize patch for mistake
Comment 5 DrSlony 2017-01-19 20:51:39 UTC 
Looks good.
Comment 6 caulier.gilles 2017-01-20 08:28:44 UTC 
Git commit 5ec20e2073752679a3acb760c63cc7f5577b9bc5 by Gilles Caulier.
Committed on 20/01/2017 at 08:27.
Pushed by cgilles into branch 'master'.

apply patch #103536
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +10   -0    utilities/queuemanager/tools/decorate/watermark.cpp

https://commits.kde.org/digikam/5ec20e2073752679a3acb760c63cc7f5577b9bc5