| Summary: | digiKam crashed after closing when BQM was used before | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Jan Wolter <online> |
| Component: | BatchQueueManager-Workflow | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | caulier.gilles, online |
| Priority: | NOR | ||
| Version: | 4.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/008fd43a16b35077ea21257039b384278a8b6be5 | Version Fixed In: | 4.6.0 |
| Sentry Crash Report: | |||
|
Description
Jan Wolter
2014-12-05 08:29:53 UTC
What the list of tool assigned to the queue ? What the settings to all tools ? What the main settings applied to the queue ? How many files must be processing by the queue ? Gilles Caulier I assigned only one tool to the queue: Convert to Jpeg. The settings there were: jpeg quality: 100 and Chroma subsampling: None. The Raw decoding settings were: - enabled 16 bits color depth - enabled Interpolate RGB as four colors - Quality: AHD v2 - enabled false colors in highlights - enabled auto brightness All other settings were default. I added only one .orf file to the BQM. I hope this information is sufficient to reproduce the problem on your computer. Following your trace : #7 0x000000000076b77d in Digikam::BatchTool::~BatchTool (this=0x1c4d4e0, __in_chrg=<optimized out>) at /home/jan/Downloads/digikamGIT/core/utilities/queuemanager/manager/batchtool.cpp:141 #8 0x0000000000799195 in Digikam::Convert2JPEG::~Convert2JPEG (this=0x1c4d4e0, __in_chrg=<optimized out>) at /home/jan/Downloads/digikamGIT/core/utilities/queuemanager/basetools/convert/convert2jpeg.cpp:56 You have a JPEG converter tool assigned in BQM. It crash here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/queuemanager/basetools/convert/convert2jpeg.cpp#L56 This appear when parent tool class want to delete instance of settings widget relevant : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/queuemanager/manager/batchtool.cpp#L141 This is fully relevant of my commit here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/04f3b6d9efba2aaca8026c7e41d36bef594539b9 ... dedicated to fix a memory leak reported by SCAN coverity static analyser. What happen when you comment line 141 from BatchTool class ? Gilles Caulier Git commit a7c291050cb24c6c47ba419dc4657e737a10092e by Gilles Caulier. Committed on 05/12/2014 at 11:03. Pushed by cgilles into branch 'master'. delete later settings widget to prevent crash when BQM is closed. M +3 -1 utilities/queuemanager/manager/batchtool.cpp http://commits.kde.org/digikam/a7c291050cb24c6c47ba419dc4657e737a10092e Jan, Check if my previous commit fix the problem on your computer. Note : there is no crash before and after this commit on my computer. Gilles Caulier Git commit 008fd43a16b35077ea21257039b384278a8b6be5 by Gilles Caulier. Committed on 05/12/2014 at 13:14. Pushed by cgilles into branch 'master'. no need to delete settings widget here. Owner is passed to ToolSettingsView, which will delete instance, even if Valgrind report a memory leak. FIXED-IN: 4.6.0 M +3 -2 utilities/queuemanager/manager/batchtool.cpp http://commits.kde.org/digikam/008fd43a16b35077ea21257039b384278a8b6be5 Hi Gilles, I tested on my computer and the problem does not occur anymore! Git commit c6a32e47b0ee010fcae4203db41a74c2e8c916cc by Maik Qualmann. Committed on 25/12/2018 at 15:38. Pushed by mqualmann into branch 'master'. fix memory leak in the BQM tool All settings widgets of the BQM tools were created at program start and not deleted. Digikam now consumes about 30MB less memory after the program starts. M +7 -3 core/utilities/queuemanager/manager/batchtool.cpp M +5 -0 core/utilities/queuemanager/manager/batchtool.h M +1 -2 core/utilities/queuemanager/manager/batchtoolsfactory.cpp M +28 -10 core/utilities/queuemanager/views/assignedlist.cpp M +5 -0 core/utilities/queuemanager/views/toolsettingsview.cpp https://commits.kde.org/digikam/c6a32e47b0ee010fcae4203db41a74c2e8c916cc Git commit 6bb4617ff948851c0cbe4dead5772eecfdd7c634 by Maik Qualmann. Committed on 25/12/2018 at 17:27. Pushed by mqualmann into branch 'master'. prevent QTimer error messages if delete settings widget M +4 -3 core/utilities/queuemanager/manager/batchtool.cpp M +2 -3 core/utilities/queuemanager/manager/batchtool.h M +2 -2 core/utilities/queuemanager/views/toolsettingsview.cpp https://commits.kde.org/digikam/6bb4617ff948851c0cbe4dead5772eecfdd7c634 |