Bug 341482

Summary: umbrello-4.14.3/umbrello/widgets/associationline.cpp:862: bad call to abs ?
Product: [Applications] umbrello Reporter: dcb314
Component: generalAssignee: Umbrello Development Group <umbrello-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 2.15.0 (KDE 14.12.0)
Sentry Crash Report:

Description dcb314 2014-12-02 09:51:07 UTC
umbrello-4.14.3/umbrello/widgets/associationline.cpp:862:24: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]

        qreal deltaX = abs(start.x() - end.x());
        qreal deltaY = abs(start.y() - end.y());

Maybe fabs would be better.


Reproducible: Always
Comment 1 Ralf Habacker 2014-12-02 10:01:13 UTC
Git commit f510078525a8aa1e2cc1866824fd159b0db2a49b by Ralf Habacker.
Committed on 02/12/2014 at 09:56.
Pushed by habacker into branch 'Applications/14.12'.

Fix warning: 'Using integer absolute value function 'abs' when argument is of floating point type'.
FIXED-IN:2.15.0 (KDE 14.12.0)

M  +2    -2    umbrello/widgets/associationline.cpp

http://commits.kde.org/umbrello/f510078525a8aa1e2cc1866824fd159b0db2a49b
Comment 2 Ralf Habacker 2014-12-09 06:00:17 UTC
Git commit f4a950262f9542e9ce6447393b54a0b6f9f97b6e by Ralf Habacker.
Committed on 02/12/2014 at 09:56.
Pushed by habacker into branch 'work/73847'.

Fix warning: 'Using integer absolute value function 'abs' when argument is of floating point type'.
FIXED-IN:2.15.0 (KDE 14.12.0)

M  +2    -2    umbrello/widgets/associationline.cpp

http://commits.kde.org/umbrello/f4a950262f9542e9ce6447393b54a0b6f9f97b6e