Bug 341379

Summary:	Advanced slideshow crashes if it runs manually backwards [patch]
Product:	[Applications] digikam	Reporter:	Lutz Mändle <lmaendle>
Component:	Plugin-Generic-Presentation	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	caulier.gilles
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/kipi-plugins/f05a27e60e5d60d90c109a6a2d6e43e3ddbad45e	Version Fixed In:	4.6.0
Attachments:	Patch for the slideshowloader of the advanced slideshow

Description Lutz Mändle 2014-11-28 21:18:26 UTC

In an advanced slideshow the pictures can switched manually with the mouse via the buttons in the slideplaybackwidget in the upper right corner of the screen. If someone runs backwards through the picturelist digikam crashes if it should switch from the first picture backwards to the last picture.

Reproducible: Always

Steps to Reproduce:
1. Start an advanced slideshow in digikam, all types except KenBurns
2. Move the mouse in the upper right croner of the screen
3. Click on the skip backward button, repeat this until the first picture is shown
4. Click on the skip backward button again

Actual Results:  
Digikam crashes

Expected Results:  
Digikam should display the last picture of the slideshow

Comment 1 Lutz Mändle 2014-11-28 21:19:48 UTC

Created attachment 89761 [details]
Patch for the slideshowloader of the advanced slideshow

The attached patch corrects the described problem.

Comment 2 caulier.gilles 2014-11-28 21:48:11 UTC

Git commit f05a27e60e5d60d90c109a6a2d6e43e3ddbad45e by Gilles Caulier.
Committed on 28/11/2014 at 21:46.
Pushed by cgilles into branch 'master'.

apply patch #89761 from Lutz Mandle to fix navigation between items into Advanced SlideShow
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +1    -1    advancedslideshow/plugin/slideshowloader.cpp

http://commits.kde.org/kipi-plugins/f05a27e60e5d60d90c109a6a2d6e43e3ddbad45e

Comment 3 caulier.gilles 2014-11-28 21:54:49 UTC

Git commit 3edbcbd5b60d45c8be75169b691cc073cb91bdf0 by Gilles Caulier.
Committed on 28/11/2014 at 21:54.
Pushed by cgilles into branch 'frameworks'.

backport commit #http://commits.kde.org/kipi-plugins/f05a27e60e5d60d90c109a6a2d6e43e3ddbad45e from git/master to frameworks branch

M  +1    -1    PORT.KF5/advancedslideshow/plugin/slideshowloader.cpp

http://commits.kde.org/kipi-plugins/3edbcbd5b60d45c8be75169b691cc073cb91bdf0