Bug 341298

Summary: MetaEngine bad if test ?
Product: digikam Reporter: dcb314
Component: Portability-CompilationAssignee: Digikam Developers <digikam-bugs-null>
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 4.5.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 4.6.0

Description dcb314 2014-11-26 17:54:08 UTC
BUILD/libkexiv2-4.14.3/libkexiv2/kexiv2exif.cpp:934:45: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

    if ((orientation != ORIENTATION_NORMAL) || (orientation != ORIENTATION_UNSPECIFIED))

Reproducible: Always
Comment 1 caulier.gilles 2014-11-26 22:29:17 UTC
Git commit df4f4dc2e4c8c3182981c636b5797181d61934e5 by Gilles Caulier.
Committed on 26/11/2014 at 22:28.
Pushed by cgilles into branch 'master'.

wrong test : this must be an AND operator, not OR
FIXED-IN: 4.6.0

M  +1    -1    libkexiv2/kexiv2exif.cpp