Summary: | Top and Bottom Margins in the Notification are not the same | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Vishesh Handa <me> |
Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleixpol, kde |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/plasma-workspace/4c097829138ae5a8ccd78b1a10b11f35813a3efa | Version Fixed In: | |
Attachments: |
An Image showing the margin problem
Patch that should fix this |
Created attachment 89711 [details]
Patch that should fix this
Can you test this patch? The margins are now added outside the Math.max (not having a body text is not a valid usecase imho but still shouldn't break then but the margins were not added to the minimum size which is the icon size)
FWIW, the patch looks sane to me, maybe make it into a review request? Git commit 3f6e5bd7a8956f3a0d43cddea4a084d66d3e5479 by Kai Uwe Broulik. Committed on 25/11/2014 at 11:03. Pushed by broulik into branch 'master'. Fix dialog minimum height (always add the margins afterwards) REVIEW: 121228 M +1 -1 applets/notifications/package/contents/ui/NotificationItem.qml http://commits.kde.org/plasma-workspace/3f6e5bd7a8956f3a0d43cddea4a084d66d3e5479 Thanks. Much much better. It's still off by quite a few pixels but that's probably the annoying icons which do not have consistent spacing. Git commit 4c097829138ae5a8ccd78b1a10b11f35813a3efa by Martin Klapetek, on behalf of Kai Uwe Broulik. Committed on 25/11/2014 at 11:03. Pushed by mklapetek into branch 'Plasma/5.1'. Fix dialog minimum height (always add the margins afterwards) REVIEW: 121228 M +1 -1 applets/notifications/package/contents/ui/NotificationItem.qml http://commits.kde.org/plasma-workspace/4c097829138ae5a8ccd78b1a10b11f35813a3efa |
Created attachment 89710 [details] An Image showing the margin problem The margins on the top and bottom should be the same. $ notify-send --icon='nepomuk' 'The top and bottom margins in this notification are not the same'