Summary: | Add pkg-config fallback to find Wayland | ||
---|---|---|---|
Product: | [Frameworks and Libraries] extra-cmake-modules | Reporter: | Andreas Müller <schnitzeltony> |
Component: | general | Assignee: | Alex Merry <alex.merry> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | ecm-bugs-null, mgraesslin, schnitzeltony |
Priority: | NOR | ||
Version First Reported In: | 5.24.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | patch |
I think the patch is wrong (though I'm not a CMake expert). I think this should rather go directly into the find wayland package script in ECM. well, are the required components installed and is the installed version correct ? FindWayland.cmake in ECM does : include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake) which does : include(${CMAKE_CURRENT_LIST_DIR}/../modules/ECMFindModuleHelpers.cmake) and the ecm_find_package_handle_library_components macro in ECMFindModuleHelpers.cmake does : find_package(PkgConfig) (line 217) Conclusion, if there's a problem, this commit just hides it. No news. Closing |
Created attachment 89660 [details] patch Fix configuration for build systems missing wayland cmake-files