| Summary: | Notifications show < instead of < | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Albert Astals Cid <aacid> |
| Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bhush94, kde, kde |
| Priority: | NOR | ||
| Version: | 5.1.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
It works fine with Quassel, I wonder if Konversation does some escaping. Can you please stop plasmashell, run it from konsole and then try to reproduce (have someone send you <text>), then look at the konsole for "New Notification", is the text there also escaped? That prints the raw string as received from the application. Ok, we have investigated and know what's wrong and also working on a solution. Should be fixed by [1] and [2], please try again with recent plasma-workspace, thanks! [1] http://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=eaa8aaccf76628b725d93797f21c902665c59d33 [2] http://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=f02dac6dd9d60760edb8ae6c52435bd6d3f26833 No Plasma/5.1 commits? FWIW i added
textFormat: Text.StyledText
to the PlasmaComponents.Label {
in NotificationPopup.qml of Plasma/5.1 and it got fixed, maybe we can backport the fix?
The change is rather invasive in terms of potential application breakage. If an application is not escaping <>& properly it will cut off the notification or truncate parts. You need to backport the \n → <br> fix in the dataengine, too, otherwise most notifications won't have line-breaks anymore. I leave the decision to Martin K who is maintainer of notifications but I'd prefer the patch not to be in 5.1.x to give us time to iron out potential misuse. Which misuse? Plasma 4 did it right, and so do other notification clients, who may be doing it right? The very small minority of KF5 users? The notifications were mostly fully rewritten for Plasma5 and the commits above change the behavior rather radically. Plasma 5.1.2 is three weeks away, I'll keep an eye on this and merge it to stable if all is ok. Kai, your commits you linked fixed this right? Yes. Only committed to mater, though. I was planning to close this once it is cherry-picked to stable (as we wanted to put through some testing first as mentioned in comment #6 and #8 and it's a bug against stable after all) and also after a regression we introduced by these changes gets fixed. I shall do so tomorrow. Ok, all the fixes have been merged to stable and will be released with Plasma 5.1.2. |
Created attachment 89610 [details] Screenshot This is from konversation using kdelibs4. Under Plasma 4 these notifications showed fine, now they show < instead of <