Bug 340804

Summary:	OTR settings strings are untranslatable
Product:	[Unmaintained] telepathy	Reporter:	André Marcelo Alvarenga <alvarenga>
Component:	general	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aspotashev, lueck
Priority:	NOR
Version:	0.9.0
Target Milestone:	Future
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/telepathy-text-ui/8d6f4b7f91ea66086a46a81c6111dab825b7fb63	Version Fixed In:	15.04.1
Sentry Crash Report:

Description André Marcelo Alvarenga 2014-11-10 01:46:24 UTC

All ktp-text-ui/config/otr-config.ui strings are not present in kcm_ktp*.pot
Messages.sh do not include this file.

Reproducible: Always

Steps to Reproduce:
1. Open Configure - Chat Application dialog and see untranslatable strings in OTR page.

Comment 1 Burkhard Lück 2014-11-10 09:52:54 UTC

in addition ktp-text-ui/config has some more missing strings in kcm_ktp*.pot

appearance-config-tab.cpp -> 39 strings

messages-config.cpp -> 1 string

otr-config.cpp -> 8 strings

Comment 2 Alexander Potashev 2015-05-04 18:24:19 UTC

Git commit 2f5d729b83b05dd6741ed81d8460cfea2cbbda1a by Alexander Potashev.
Committed on 04/05/2015 at 19:11.
Pushed by aspotashev into branch 'Applications/15.04'.

Change qt5_wrap_ui() to ki18n_wrap_ui() to get dialogs translated via KI18n

These dialogs were untranslatable because of wrong translation domain.

M  +3    -3    config/CMakeLists.txt
M  +1    -1    filters/latex/CMakeLists.txt
M  +1    -1    lib/CMakeLists.txt
M  +1    -1    logviewer/CMakeLists.txt
M  +1    -1    logviewer/config/CMakeLists.txt

http://commits.kde.org/telepathy-text-ui/2f5d729b83b05dd6741ed81d8460cfea2cbbda1a

Comment 3 Alexander Potashev 2015-05-04 18:24:19 UTC

Git commit 8d6f4b7f91ea66086a46a81c6111dab825b7fb63 by Alexander Potashev.
Committed on 04/05/2015 at 19:11.
Pushed by aspotashev into branch 'Applications/15.04'.

Move config/* into subdirectories and fix untranslatable strings

Fixed untranslatable strings by:
 1. Extracting strings from all *.cpp and *.ui files,
 2. Setting the correct translations domains for each KCM.

M  +4    -59   config/CMakeLists.txt
D  +0    -8    config/Messages.sh
A  +24   -0    config/appearance/CMakeLists.txt
A  +4    -0    config/appearance/Messages.sh
R  +0    -0    config/appearance/appearance-config-tab.cpp [from: config/appearance-config-tab.cpp - 100% similarity]
R  +0    -0    config/appearance/appearance-config-tab.h [from: config/appearance-config-tab.h - 100% similarity]
R  +0    -0    config/appearance/appearance-config.cpp [from: config/appearance-config.cpp - 100% similarity]
R  +0    -0    config/appearance/appearance-config.h [from: config/appearance-config.h - 100% similarity]
R  +0    -0    config/appearance/appearance-config.ui [from: config/appearance-config.ui - 100% similarity]
R  +0    -0    config/appearance/kcm_ktp_chat_appearance.desktop [from: config/kcm_ktp_chat_appearance.desktop - 100% similarity]
A  +23   -0    config/behavior/CMakeLists.txt
A  +4    -0    config/behavior/Messages.sh
R  +0    -0    config/behavior/behavior-config.cpp [from: config/behavior-config.cpp - 100% similarity]
R  +0    -0    config/behavior/behavior-config.h [from: config/behavior-config.h - 100% similarity]
R  +0    -0    config/behavior/behavior-config.ui [from: config/behavior-config.ui - 100% similarity]
R  +0    -0    config/behavior/kcm_ktp_chat_behavior.desktop [from: config/kcm_ktp_chat_behavior.desktop - 100% similarity]
A  +20   -0    config/messages/CMakeLists.txt
A  +2    -0    config/messages/Messages.sh
R  +0    -0    config/messages/kcm_ktp_chat_messages.desktop [from: config/kcm_ktp_chat_messages.desktop - 100% similarity]
R  +0    -0    config/messages/messages-config.cpp [from: config/messages-config.cpp - 100% similarity]
R  +0    -0    config/messages/messages-config.h [from: config/messages-config.h - 100% similarity]
A  +24   -0    config/otr/CMakeLists.txt
A  +4    -0    config/otr/Messages.sh
R  +0    -0    config/otr/kcm_ktp_chat_otr.desktop [from: config/kcm_ktp_chat_otr.desktop - 100% similarity]
R  +0    -0    config/otr/otr-config.cpp [from: config/otr-config.cpp - 100% similarity]
R  +0    -0    config/otr/otr-config.h [from: config/otr-config.h - 100% similarity]
R  +0    -0    config/otr/otr-config.ui [from: config/otr-config.ui - 100% similarity]

http://commits.kde.org/telepathy-text-ui/8d6f4b7f91ea66086a46a81c6111dab825b7fb63