Bug 340781

Summary: KTP icon does not change when connection lost.
Product: [Unmaintained] telepathy Reporter: Reshad Patuck <reshad>
Component: generalAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, loic.yhuel, simonandric5, smithjd15
Priority: NOR    
Version: 0.9.0   
Target Milestone: Future   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 18.04
Sentry Crash Report:

Description Reshad Patuck 2014-11-09 06:37:45 UTC
Hi,

I have noticed that the KTP icon stays green (even when disconnected). 

From the irc channel I know that this is because of the Requested status as "online"

Steps o reproduce:
- Connected to XMPP server when connected to the internet.
- Remove network cable, mc-tool dump shows Automatic: available (2); Current: offline (1); Requested: available (2); Changing: no
- Reconnect network cable, mc-tool dump shows Automatic: available (2); Current: offline (1); Requested: available (2); Changing: no

All the while the status icon remains green without the spinning icon.

In my opinion the status icon should be as follows:
- When connected and not changing: green icon with no spinning status change indicators.
- When disconnected and not changing: grey icon with no spinning status change indicator.
- When disconnected and changing to connected: green icon with spinning status change indicators.

This implies that while changing is yes, use the requested status for the icon with the spinning indicators and when changing is no use the current status for the icon.


------ mc-tool dump -----

    When offline (network cable unplugged for 2 min):
    $ mc-tool dump
         Account: gabble/jabber/rap_40xxxxx0
    Display Name: RAP
      Normalized: rap@xxxxx
         Enabled: enabled
            Icon: im-jabber
        Connects: only when requested
        Nickname: rap
         Service: jabber
     
    Presences:
       Automatic: available (2) ""
         Current: offline (1) ""
       Requested: available (2) ""
        Changing: no
     
          (string) server = xxxxx
           (GStrv) fallback-socks5-proxies = [""]
          (string) resource = kde-telepathy-xxxxx
          (string) account = rap@xxxxx
     
    ------------------------------------------------------
     
    When Online (3-4 min after cable reattached, manually setting status to online):
    $ mc-tool dump
         Account: gabble/jabber/rap_40xxxxx0
    Display Name: RAP
      Normalized: rap@xxxxx
         Enabled: enabled
            Icon: im-jabber
        Connects: only when requested
        Nickname: rap
         Service: jabber
     
    Presences:
       Automatic: available (2) ""
         Current: available (2) ""
       Requested: available (2) ""
        Changing: no
     
          (string) server = xxxxx
           (GStrv) fallback-socks5-proxies = [""]
          (string) resource = kde-telepathy-xxxxx
          (string) account = rap@xxxxx


Reproducible: Always




This bug is similar to "Bug 337881 - Telepathy tries to connect even when network is down".
Comment 1 Martin Klapetek 2015-07-31 16:15:05 UTC
*** Bug 349765 has been marked as a duplicate of this bug. ***
Comment 2 Martin Klapetek 2015-07-31 16:15:07 UTC
*** Bug 347321 has been marked as a duplicate of this bug. ***
Comment 3 Jamie Smith 2017-11-22 01:46:12 UTC
This should be fixed as of this commit: https://commits.kde.org/ktp-common-internals/5ed8ed322a28f1c947de43daaa3c7c0ab009e101