| Summary: | Detection button should inform the user when he clicked an unmanaged window | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Thomas Lübking <thomas.luebking> |
| Component: | kcm_kwinrules | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | isma.af, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/1829dce1a9a0691a6174bb01195f68c505e1dce1 | Version Fixed In: | 5.21 |
|
Description
Thomas Lübking
2014-10-29 19:41:39 UTC
Git commit f397f072df1ed7476dc7cf907775d93575e42625 by Ismael Asensio. Committed on 28/10/2020 at 20:41. Pushed by iasensio into branch 'master'. Reply a meaningful dBus error when detecting unmanaged windows Currently, the method `createErrorReply()` with empty strings errors out and the client gets no answer: ``` QDBusConnection: error: could not send error message to service "": Error name cannot be empty ``` Simple test: qdbus org.kde.KWin /KWin org.kde.KWin.showDebugConsole qdbus org.kde.KWin /KWin org.kde.KWin.queryWindowInfo Error name uses D-Bus Interface-like notation as suggested in https://doc.qt.io/qt-5/qdbuserror.html#name M +3 -1 dbusinterface.cpp https://invent.kde.org/plasma/kwin/commit/f397f072df1ed7476dc7cf907775d93575e42625 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/407 Git commit 1829dce1a9a0691a6174bb01195f68c505e1dce1 by Ismael Asensio. Committed on 13/11/2020 at 19:29. Pushed by iasensio into branch 'master'. kwinrules: Show error when detected window is unmanaged M +20 -2 kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml M +3 -0 kcmkwin/kwinrules/rulesmodel.cpp M +2 -0 kcmkwin/kwinrules/rulesmodel.h https://invent.kde.org/plasma/kwin/commit/1829dce1a9a0691a6174bb01195f68c505e1dce1 |