Summary: | Okular unable to open .cbr files due to inabillity to find unrar due to unrar having removed the --version flag in unrar 5.2.1 | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Jörg Schuck <joerg_schuck> |
Component: | Comicbook backend | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid, legolegs, luigi.toscano, yurchor |
Priority: | NOR | ||
Version: | 0.20.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/okular/717c4b0f6a3a1bc8a2ac02a4028be62c4b4996e3 | Version Fixed In: | 4.14.3 |
Attachments: |
Possible patch to fix the bug
Patch with a fallback to -v on --version error. My version of the patch |
Description
Jörg Schuck
2014-10-24 23:53:22 UTC
Created attachment 89312 [details]
Possible patch to fix the bug
Can somebody test it (I have no cbr at hand)?
That patch compiles and works for me. No, the patch breaks the detection of the unrar-free version, which only accepts --version (at least for 0.0.1+cvs20140707-1 which is in Debian. Created attachment 89316 [details]
Patch with a fallback to -v on --version error.
This patch should be better then. It only falls back to -v if --version returns an the ERROR line.
It could use some refactoring though.
Created attachment 89341 [details]
My version of the patch
Can you guys check if that works for you? I'd prefer it written like that if you can confirm it works
Compiles and works with unrar 1:5.2.1-1 and 1:5.1.7-1. Git commit 717c4b0f6a3a1bc8a2ac02a4028be62c4b4996e3 by Albert Astals Cid. Committed on 27/10/2014 at 21:34. Pushed by aacid into branch 'KDE/4.14'. Fix unrar detection for versions that don't support --version Based on patches by Yuri Chornoivan and Jörg Schuck FIXED-IN: 4.14.3 M +6 -3 generators/comicbook/unrar.cpp http://commits.kde.org/okular/717c4b0f6a3a1bc8a2ac02a4028be62c4b4996e3 *** Bug 347634 has been marked as a duplicate of this bug. *** |