| Summary: | Apps using KStatusNotifierItem crash when plasmashell is quit | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knotifications | Reporter: | Eike Hein <hein> |
| Component: | general | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | bhush94, hrvoje.senjan, kde, kdelibs-bugs, mail, simonandric5 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/frameworkintegration/072679bd7044021b08a3ef04909719b5b3479f58 | Version Fixed In: | |
|
Description
Eike Hein
2014-10-05 15:36:50 UTC
Version info: Qt 5.4 branch tip, KF5 master branch tip. Possibly related to bug 335284. Possibly related to the recent changes of KSNI :S When is it crashing? Or how to reproduce this crash? Just kquitapp5 is enough for me. But I just realized that I use wmsystray for ibus, so KSNI probably spins down to x11embed then. I cannot reproduce at all even with wmsystemtray running (with dropbox icon). I'll wait if more reports will come in *** Bug 339941 has been marked as a duplicate of this bug. *** This keeps happening here - and I don't use wmsystemtray anymore, btw. Unfortunately you are still the only one with this issue (reported, anyway) and I honestly have no clue what's going south. Maybe it's libdbusmenu-qt? I believe this is stupid question but is it "recent enough"? i also still have the issue on regular basis (the dup 339941) (regular means, at least on 70% after quitting plasmashell) libdbusmenu-qt(5) is at 0.9.3+14.10.20140619 this iirc only started to happen after David's 'Qt 5.4 fix' Can you guys try to revert that commit and see if it really is that one? Actually there are two: b0e56119ab78e839fdaa7bf47370510dd0f3c8b1 fdc1ee538d249845061105412f28017ac77f618d Try just one first and see if it fixes it. No luck, with either one or both reverted I still see KMix crash or quit when restarting plasmashell. *** Bug 339307 has been marked as a duplicate of this bug. *** Alright, this seems related to Qt5.4. Now I can reproduce too, so investigating. Git commit 072679bd7044021b08a3ef04909719b5b3479f58 by Martin Klapetek. Committed on 14/01/2015 at 15:13. Pushed by mklapetek into branch 'master'. Properly check for systray being available The "org.kde.StatusNotifierWatcher" is just a watcher/helper, not the actual systray object, that's "org.kde.StatusNotifierHost-$PID". Because Plasma appends the PID (as per the specification), we cannot check directly for it being present on the bus, so we check the org.kde.StatusNotifierWatcher.IsStatusNotifierHostRegistered property that's meant to be used for this. Plus QSystemTrayIcon::isSystemTrayAvailable() is actually returning always true, because the Watcher is in kded and is /always/ present. This also fixes many apps with KSNI crashing on plasma exit, bug 339707 (though I believe this is not the direct cause for that bug) REVIEW: 121885 CHANGELOG M +7 -5 src/platformtheme/kdeplatformsystemtrayicon.cpp http://commits.kde.org/frameworkintegration/072679bd7044021b08a3ef04909719b5b3479f58 |