Bug 339524

Summary:	Identity class miss d private container to improve binary compatibility [patch]
Product:	[Applications] digikam	Reporter:	caulier.gilles
Component:	Faces-Detection	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, marcel.wiesweg, simonandric5, tl
Priority:	NOR
Version:	4.4.0
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	http://commits.kde.org/libkface/cc6a4ca7d7b61eeebe8438bcec2a93659af2a745	Version Fixed In:	4.5.0
Sentry Crash Report:
Attachments:	patch for libkface patch for digiKam patch for libkface (v2)

Description caulier.gilles 2014-09-30 08:01:06 UTC

In order to preserve binary compatibility, Identity class need new accessor methods to play with internal members. Currently all members are public. This need to be changed as other class from libkface.

Reproducible: Always

Comment 1 caulier.gilles 2014-09-30 08:08:11 UTC

Created attachment 88899 [details]
patch for libkface

Path to make internal members private and add new methods to access on private members.

Comment 2 caulier.gilles 2014-09-30 08:13:15 UTC

Marcel, 

There is a current discussion into kde-core-devel@kde.org mailing list to make libkface more public into kdegraphics component, as libkipi, libkexiv2, and libkdcraw.

This patch increase BC into Identity class in order to make this library public.

Can you check my patches please to see if all is fine for you.

Thanks in advance

Gilles Caulier

Comment 3 caulier.gilles 2014-09-30 08:21:04 UTC

Created attachment 88900 [details]
patch for digiKam

digiKam patch to use new libkface API

Comment 4 Marcel Wiesweg 2014-09-30 12:11:23 UTC

Comment on attachment 88899 [details]
patch for libkface

If we really believe we need this redirection, then the patch is ok I think

Comment 5 caulier.gilles 2014-09-30 12:25:39 UTC

Created attachment 88902 [details]
patch for libkface (v2)

Some code polish with map iterator used in Identity attibutes loop

Comment 6 Tobias Leupold 2014-09-30 16:26:33 UTC

Gilles, With v2 of your patch, KPA does not crash anymore. Everything works as before (with the patches necessary to respect the new API of course). Thanks :-)

Comment 7 caulier.gilles 2014-09-30 16:29:55 UTC

Thanks Tobias,

I propose to wait digiKam 4.4.0 release planed next Sunday evening before to apply this patch on git/master.

Gilles

Comment 8 Tobias Leupold 2014-09-30 16:43:18 UTC

I'm fine with that. I'll patch KPA git master as soon as your changes are in libkface git, and I know which version cmake has to check (at the moment, it's >=3.3.0). Perhaps you could drop me an email?

Nice to see that libkface is on it's way to be an "independent" library with an own release :-)

Comment 9 caulier.gilles 2014-10-11 09:19:06 UTC

Patches applied to git/master.

Gilles Caulier