| Summary: | "Flac" partially lowercase when ripping audio CD | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Philippe Cloutier <chealer> |
| Component: | Collections/CD | Assignee: | Amarok Bugs <amarok-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | duiliofelix |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | 2.8.0 | ||
| Target Milestone: | 2.9 | ||
| Platform: | Debian testing | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/amarok/8f5de633208bff3295e1f443f9c098142406e825 | Version Fixed/Implemented In: | 2.9 |
| Sentry Crash Report: | |||
| Attachments: | Codec choice dialog | ||
|
Description
Philippe Cloutier
2014-09-29 03:19:41 UTC
Just because it is an abbreviation (not an accronym BTW) doesn't mean it has to be uppercase. Ditto for mp3, abbreviations don't have to be uppercase in file names as grammar case rules do not apply to file names AFAIK. FWIW: you should also bugger the Xiph Foundation as they use lowercase in filenames, too: https://xiph.org/flac/faq.html#tools__wildcards_on_windows FWIW2: if it really bothers you you can easily convert this with a script. Created attachment 88892 [details]
Codec choice dialog
"FLAC" is an acronym, not merely an abbreviation. This is not about file names. The attachment illustrates what I am talking about. Right, you didn't specify it was in the text of the dialog. Marking this as a Junior Job, will handle this myself once I find time to. Hi, I want to start to contribute with free software, so can I take this job? (Not sure if here is the proper place to ask it, sorry) Also, just to make sure, all I have to do is to put the words "Flac", "Ogg", "Wav" and "Mp3" to uppercase, right? Hi Duilio,
This looks like an ideal job to familiarize with KDE development. I am sure you can take it and submit a patch here.
"Ogg" is not an acronym and should stay as is. I am less sure about "Wav", but "WAV" is acceptable according to Wikipedia ("WAVE" is also used).
Please only change FLAC and MP3, the others are not acronyms. Ok, done. I just submitted the changes on https://git.reviewboard.kde.org/r/120930/ That's the right proceedment to make a contribution? Thank you Duilio, but I suppose this patch doesn't fix the option labels in the Available formats zone, does it? Hmm, thats right... my bad. I gonna fix that and correct the patch. Sorry. Ok, now the options are fixed too, sorry for that. There is any more errors for this bug? I didn't test, but that looks good to me. Git commit 8f5de633208bff3295e1f443f9c098142406e825 by Myriam Schweingruber. Committed on 01/11/2014 at 11:58. Pushed by schweingruber into branch 'master'. Correct lowercase for FLAC and MP3 Change lowercase instances of FLAC and MP3, Patch kindly provided by Duilio Felix FIXED-IN: 2.9 REVIEW: 120930 M +2 -2 src/core-impl/collections/audiocd/FormatSelectionDialog.cpp M +2 -2 src/core-impl/collections/audiocd/FormatSelectionDialog.ui http://commits.kde.org/amarok/8f5de633208bff3295e1f443f9c098142406e825 |