| Summary: | GeoDataPlacemark::operator= seems incomplete | ||
|---|---|---|---|
| Product: | [Applications] marble | Reporter: | Dennis Nienhüser <nienhueser> |
| Component: | general | Assignee: | Bernhard Beschow <shentey> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/marble/b2cd9e64d53f7f213d0b2959ca8da7ae704d1506 | Version Fixed In: | |
| Sentry Crash Report: | |||
Git commit b2cd9e64d53f7f213d0b2959ca8da7ae704d1506 by Bernhard Beschow. Committed on 27/09/2014 at 16:47. Pushed by beschow into branch 'master'. don't copy GeoDataObject part of features M +1 -3 src/lib/marble/geodata/data/GeoDataFeature.cpp M +1 -1 src/lib/marble/geodata/data/GeoDataPlacemark.cpp M +0 -2 tests/TestGeoDataCopy.cpp http://commits.kde.org/marble/b2cd9e64d53f7f213d0b2959ca8da7ae704d1506 |
Adding GeoDataPlacemark::operator= in eaf2347 broke Marble::RouteRequestTest. Adding GeoDataFeature::operator=( other ); at the start of the method would fix that test but breaks TestGeoDataCopy (parent seems copied then). Since you (Bernhard) looked into all that anyway I'll leave it up to you to figure out a nice solution :) ********* Start testing of Marble::RouteRequestTest ********* Config: Using QTest library 4.8.6, Qt 4.8.6 PASS : Marble::RouteRequestTest::initTestCase() PASS : Marble::RouteRequestTest::defaultConstructor() FAIL! : Marble::RouteRequestTest::reverse() Compared values are not the same Actual (request[1].name()): B Expected (QString("A")): A Loc: [/home/nienhues/marble/src/tests/RouteRequestTest.cpp(61)] PASS : Marble::RouteRequestTest::cleanupTestCase() Totals: 3 passed, 1 failed, 0 skipped ********* Finished testing of Marble::RouteRequestTest *********