| Summary: | meinproc test using data from install rather than build dir | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kdoctools | Reporter: | Harald Sitter <sitter> |
| Component: | general | Assignee: | Documentation Editorial Team <kde-doc-english> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs, luigi.toscano, simonandric5 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdoctools/ae8c4837a5c2f52528a42ad6565d7fdea00bbc0d | Version Fixed In: | 5.3.0 |
| Sentry Crash Report: | |||
| Attachments: | patch using --srcdir on meinproc5 | ||
Created attachment 88791 [details]
patch using --srcdir on meinproc5
Attached a patch using --srcdir to make meinproc find the xsl files that are alraedy being replicated into src/customization.
Other than using --srcdir there appear (with my very limited overview on the matter) exactly two options:
- detect missing assets and let the test pass (assuming that we are running pre-install, and even post-install failing on missing assets would really be more validation of whether the installation and envrionment is suitable than a test of meinproc)
- replicate an installation path structure in the build dir and use XDG_DATA_DIRS to make meinproc5 find it, at which point the test becomes more of an integration test than anything else
(In reply to Harald Sitter from comment #1) > - replicate an installation path structure in the build dir and use > XDG_DATA_DIRS to make meinproc5 find it, at which point the test becomes > more of an integration test than anything else This is the solution I would like to have, but for now the codepath which forces srcdir (used during the generation of the documentation shipped with kdoctools) is a test. Please commit (and if you can, backport to the corresponding kdelibs/kdoctools test). Git commit a1efbd838538a6ce32ff994eb8fd8e4260ec3b60 by Harald Sitter. Committed on 24/09/2014 at 09:12. Pushed by sitter into branch 'KDE/4.14'. make meinproc test work before running make install this is achieved by using --srcdir on meinproc5 to define the path where to look for the customization directory note: builddir/customization is populated by the relevant install macros in the kdoctools directory FIXED-IN: 4.14.2 M +1 -1 kdoctools/tests/CMakeLists.txt http://commits.kde.org/kdelibs/a1efbd838538a6ce32ff994eb8fd8e4260ec3b60 Git commit ae8c4837a5c2f52528a42ad6565d7fdea00bbc0d by Harald Sitter. Committed on 24/09/2014 at 09:12. Pushed by sitter into branch 'master'. make meinproc test work before running make install this is achieved by using --srcdir on meinproc5 to define the path where to look for the customization directory note: builddir/src/customization is populated by the relevant install macros in src/ FIXED-IN: 5.3.0 M +1 -1 autotests/CMakeLists.txt http://commits.kde.org/kdoctools/ae8c4837a5c2f52528a42ad6565d7fdea00bbc0d |
the test should try to find the xsl from the build dir, not the installed path. otherwise it would be testing against the installed version, rather than the to-be-installed one. side effect is that if the test is run before the initial install the xsl lookup will fail entirely (which is also a problem as far as clean distribution package builds are concerned as they wouldn't ever have a previous install to test against): /usr/bin/ctest --force-new-ctest-process -j4 Test project /build/buildd/kdoctools-5.2.0+git20140922.1336/obj-i686-linux-gnu Start 1: meinproc_template 1/1 Test #1: meinproc_template ................***Failed 0.01 sec Could not locate file "kf5/kdoctools/customization" in ("/home/buildd/.local/share", "/usr/local/share", "/usr/share") Could not locate file "kf5/kdoctools/customization/kde-chunk.xsl" in ("/home/buildd/.local/share", "/usr/local/share", "/usr/share") Error: Unable to find the stylesheet named "customization/kde-chunk.xsl" in dtd resources Reproducible: Always