| Summary: | Existing tags from image metadata are removed when adding new tags to multiple images | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Paul <pip.kde> |
| Component: | Tags-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, jfd5xte, kde.bugs, online, veaceslav.munteanu90 |
| Priority: | NOR | ||
| Version: | 4.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/068f5924f08ba45fb9b1c4dff907eba186b9ff5f | Version Fixed In: | 4.4.0 |
| Sentry Crash Report: | |||
| Attachments: |
Correct tags in dk database
Missing image meta-data Image metadata after executing 'Image - Write Metadata to Image' |
||
|
Description
Paul
2014-09-20 11:08:52 UTC
Veaceslav, As expected, this entry have been created (:=)))... Gilles So I made a scenario: 1st picture tag "A"; 2nd picture tags "A", "B" 3rd picture tag "B" after adding one tag to all 3 images above, I have all tags correctly written to metadata. Gilles, can you reproduce this? @ Veaceslav I've just tried your simple scenario, and that indeed worked as expected, odd... With a 'real world' case this is the result, shown in the attached screen-shots. The image initially had all of the tags shown in the tool-tip apart from 'Pending Print', this tag was added to this (and the other) test images. All tags, both existing and newly added are correctly shown by digiKam. The actual meta-data written to the image is shown in the second screen-shot, the only tag present is the one just added, all existing tags have been removed. Created attachment 88846 [details]
Correct tags in dk database
Created attachment 88848 [details]
Missing image meta-data
To respond about comment #2, yes i work as expected in this case for me. Gilles @ Veaceslav As an afterthought, this is the meta-data after executing 'Image - Write Metadata to Image' from within digikam. If you want the test images I'm using I can put them on dropbox... Created attachment 88849 [details]
Image metadata after executing 'Image - Write Metadata to Image'
Test case was performed using Digikam 3.5.0 on Kubuntu 14.04, and Bug was not reproduced. Correct writing of tags was observed. I have found a method to reproduce bug, running on Xubuntu with Digikam 4.3.0 Example setup with 2 files and 3 tags: Image1, tags "A", "B" Image2, tags "A", "C" Select BOTH images in the thumbnail view. Open the tags tab on the right. (Optionally enable "Tags already assigned" for clarity) Tags "A", "B", "C" will display, however only "A" will be ticked. Now if you make any changes TO THE SELECTED IMAGES and Apply, the database will be correct but only the COMMON tags will be written to the selected files. Such that if you add tag "D", the thumbnail view will show Image1, tags "A", "B", "D" Image2, tags "A", "C", "D" But the files metadata will be written as: Image1, tags "A", "D" Image2, tags "A", "D" This is quite an important issue, as there is potential for the loss of tags if one assumes that they have been correctly written to the image meta-data... @ meku Thanks for confirming this :) Ok, now I can reproduce... I used to assign tags from right-click Add Tags and it worked flawless but if you use left sidebar and apply button, it doesn't work.... Investigating... Git commit 068f5924f08ba45fb9b1c4dff907eba186b9ff5f by Veaceslav Munteanu. Committed on 04/10/2014 at 21:47. Pushed by munteanu into branch 'master'. M +1 -0 app/fileaction/databaseworkeriface.cpp M +1 -3 app/fileaction/fileworkeriface.cpp M +36 -0 app/fileaction/metadatahub.cpp M +13 -0 app/fileaction/metadatahub.h http://commits.kde.org/digikam/068f5924f08ba45fb9b1c4dff907eba186b9ff5f Whew... just in time.. one day before 4.4 release ^_^ Thanks! Appreciate the work you guys do. :) Paul, If you can test using git/master implementation including last patch from Veaceslav, it will be fine. It's always good to have different people testing a solution before a release. I will test on my computer now. Gilles Caulier I just tried with a set of 3 images selected at the same time, including already tags and other labels properties. I played to remove/add/changes digiKam properties in multiple conditions (1/2/3 images selected at the same time) to process change. In metadata (XMP digiKam namespace), all Tags are properly reflected the database content. Did i miss some test conditions here ? Gilles Caulier The main problem was disjoint tags not being applied when Apply button from left sidebar was pressed. Adding tags with the context menu worked fine. Vesaceslav, yes, i take a care to not use context menu and only perform changes through right sidebar and Apply button. I also tested this report : https://bugs.kde.org/show_bug.cgi?id=259228 and it sound not reproducible here... Gilles DO not close 259228, it's still do not work for me.... Veaceslav, Do you think that file https://bugs.kde.org/show_bug.cgi?id=204487... Can be fixed more easily since you change disjoint rules in MetadataHub. Gilles (In reply to Gilles Caulier from comment #16) > If you can test using git/master implementation including last patch from > Veaceslav, it will be fine. It's always good to have different people > testing a solution before a release. Gilles, Would like to help with testing this... but until 4.4.0 makes it into the openSuse repo won't be able to, sorry. I need to learn how to build digiKam myself :) Paul, It's explained here : https://www.digikam.org/download/GIT Gilles Caulier (In reply to Gilles Caulier from comment #23) > It's explained here : Gilles, Apologies for taking so long... :) I'm able to confirm that Vesaceslav's fix has solved the original problem. I also spent some time generally changing quite a few tags and all were written correctly to the meta-data. Thanks to you both. |