Bug 339222

Summary: On OSX there is an error whilst building Marble. Qt5 is installed.
Product: [Applications] marble Reporter: drewjpotter
Component: generalAssignee: Illya Kovalevskyy <illya.kovalevskyy>
Status: RESOLVED FIXED    
Severity: normal CC: illya.kovalevskyy, nienhueser
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: attachment-15177-0.html

Description drewjpotter 2014-09-20 09:26:15 UTC
On OSX there is an error whilst building Marble. Qt5 is installed.

[ 34%] Building CXX object src/lib/marble/CMakeFiles/marblewidget.dir/layers/PopupLayer.o
[ 35%] Building CXX object src/lib/marble/CMakeFiles/marblewidget.dir/layers/TextureLayer.o
[ 35%] Building CXX object src/lib/marble/CMakeFiles/marblewidget.dir/layers/VectorTileLayer.o
[ 35%] Building CXX object src/lib/marble/CMakeFiles/marblewidget.dir/MarbleQuickItem.o
In file included from /Users/denisepotter/marble/src/lib/marble/MarbleQuickItem.cpp:12:
/Users/denisepotter/marble/src/lib/marble/MarbleQuickItem.h:15:10: fatal error: 
      'QQuickPaintedItem' file not found
#include <QQuickPaintedItem>
         ^
1 error generated.
Comment 1 Dennis Nienhüser 2014-09-20 19:00:02 UTC
Which Qt 5.x version is that exactly? Can you verify that it has a QQuickPaintedItem installed? If yes, we might miss some dependency in cmake that ensures the include path to it is properly set. Otherwise you Qt installation might be incomplete.

Can you run make with VERBOSE=1 parameter to have it show the compiler calls and post/attach that here?
Comment 2 drewjpotter 2014-09-20 19:03:21 UTC
Created attachment 88765 [details]
attachment-15177-0.html

I am using Qt 5.3.2, I ran it with VERBOSE=1

[  1%] Building CXX object src/lib/marble/CMakeFiles/marblewidget.dir/MarbleQuickItem.o
cd /Users/denisepotter/marble/src/lib/marble && /usr/bin/c++   -DMAKE_MARBLE_LIB -DQTONLY -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_SCRIPT_LIB -DQT_SVG_LIB -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DQT_WEBKITWIDGETS_LIB -DQT_WEBKIT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -fPIC -F/usr/lib -isystem /usr/lib/QtSvg.framework/Headers -isystem /usr/lib/QtWidgets.framework/Headers -isystem /usr/lib/QtGui.framework/Headers -isystem /usr/lib/QtCore.framework/Headers -isystem /usr/mkspecs/macx-clang -isystem /System/Library/Frameworks/OpenGL.framework/Headers -I/usr/lib/QtPrintSupport.framework/Headers -isystem /usr/lib/QtNetwork.framework/Headers -isystem /usr/lib/QtScript.framework/Headers -I/usr/lib/QtTest.framework/Headers -isystem /usr/lib/QtXml.framework/Headers -I/usr/lib/QtSql.framework/Headers -I/Users/denisepotter/marble -I/Users/denisepotter/marble/src/lib/marble -I/Users/denisepotter/marble/src/lib/marble/projections -I/Users/denisepotter/marble/src/lib/marble/geodata -I/Users/denisepotter/marble/src/lib/marble/geodata/data -I/Users/denisepotter/marble/src/lib/marble/geodata/graphicsitem -I/Users/denisepotter/marble/src/lib/marble/geodata/handlers/dgml -I/Users/denisepotter/marble/src/lib/marble/geodata/parser -I/Users/denisepotter/marble/src/lib/marble/geodata/writer -I/Users/denisepotter/marble/src/lib/marble/geodata/scene -I/Users/denisepotter/marble/src/lib/marble/graphicsview -I/Users/denisepotter/marble/src -I/Users/denisepotter/marble/src/lib/marble/routing -I/Users/denisepotter/marble/src/lib/marble/geodata/handlers -I/Users/denisepotter/marble/src/lib/marble/geodata/handlers/kml -I/Users/denisepotter/marble/src/lib/marble/layers -I/Users/denisepotter/marble/src/lib/marble/cloudsync -I/Users/denisepotter/marble/src/lib/astro -isystem /usr/lib/QtWebKitWidgets.framework/Headers -isystem /usr/lib/QtWebKit.framework/Headers -I/usr/lib/QtConcurrent.framework/Headers    -O3 -DKML_LAZY_IMP -o CMakeFiles/marblewidget.dir/MarbleQuickItem.o -c /Users/denisepotter/marble/src/lib/marble/MarbleQuickItem.cpp
In file included from /Users/denisepotter/marble/src/lib/marble/MarbleQuickItem.cpp:12:
/Users/denisepotter/marble/src/lib/marble/MarbleQuickItem.h:15:10: fatal error: 
      'QQuickPaintedItem' file not found
#include <QQuickPaintedItem>
         ^
1 error generated.
make[2]: *** [src/lib/marble/CMakeFiles/marblewidget.dir/MarbleQuickItem.o] Error 1
make[1]: *** [src/lib/marble/CMakeFiles/marblewidget.dir/all] Error 2
make: *** [all] Error 2



On 20 Sep 2014, at 20:00, Dennis Nienhüser <earthwings@gentoo.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=339222
> 
> Dennis Nienhüser <earthwings@gentoo.org> changed:
> 
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |earthwings@gentoo.org
> 
> --- Comment #1 from Dennis Nienhüser <earthwings@gentoo.org> ---
> Which Qt 5.x version is that exactly? Can you verify that it has a
> QQuickPaintedItem installed? If yes, we might miss some dependency in cmake
> that ensures the include path to it is properly set. Otherwise you Qt
> installation might be incomplete.
> 
> Can you run make with VERBOSE=1 parameter to have it show the compiler calls
> and post/attach that here?
> 
> -- 
> You are receiving this mail because:
> You reported the bug.
Comment 3 Dennis Nienhüser 2014-10-19 20:29:18 UTC
> <tucnak> Earthwings: here we go.. I added `include_directories( ${Qt5Quick_INCLUDE_DIRS} )` and it actually works; hm, how did it manage to work w/o this line?

Illya, can you commit this fix please (no review needed)?
Comment 4 Illya Kovalevskyy 2014-10-19 21:01:13 UTC
Of course I can commit the fix, but there is still a little trouble with it. It's actually explained right here: http://qt-project.org/forums/viewthread/48658/. I'd better commit only when it finally compiles on my machine.
Comment 5 Dennis Nienhüser 2014-10-19 23:47:08 UTC
The target(s) also needs to link against ${Qt5Quick_LIBRARIES}. Something similar to what examples/cpp/marbleQuick2/CMakeLists.txt does in target_link_libraries.
Comment 6 Illya Kovalevskyy 2014-10-20 15:35:10 UTC
Git commit c85152d05d90121d778fc5b22cf7d13e1b95fe0d by Illya Kovalevskyy.
Committed on 20/10/2014 at 15:33.
Pushed by kovalevskyy into branch 'master'.

Fixed a bunch of compile/linking bugs for OS X

M  +2    -0    CMakeLists.txt
M  +2    -0    src/lib/marble/CMakeLists.txt

http://commits.kde.org/marble/c85152d05d90121d778fc5b22cf7d13e1b95fe0d