Bug 339213

Summary: knotes accepting notes from network does not work in 4.14 (with fix)
Product: [Applications] knotes Reporter: Silvan Calarco <silvan.calarco>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: montel, myriam
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: The patch mentioned in previous commit

Description Silvan Calarco 2014-09-19 15:38:25 UTC
On 4.14.0 I wasn't able to send knotes notes through network from one knotes to another.
When trying to send a note the akonadi_notes_agent receiver process displays this message:

  Object::connect: No such signal NoteShared::NotesNetworkReceiver::noteReceived(QString,QString)


Reproducible: Always

Steps to Reproduce:
1. Configure KNotes on the receiver computer to Accept incoming notes
2. If necessary open TCP port 24837
3. From the sender computer use the KNotes "Send..." function and send a note specifying the receiver IP address

Actual Results:  
Nothing happens on the receiver.

Expected Results:  
Have the remote note added to the notes on the receiver computer.

--- kdepim-4.14.0/agents/notesagent/notesmanager.cpp.orig       2014-09-19 16:06:52.666714071 +0200
I've fixed it with the following patch:

+++ kdepim-4.14.0/agents/notesagent/notesmanager.cpp    2014-09-19 16:06:57.744713275 +0200
@@ -163,7 +163,7 @@
 
     if ( s ) {
         NoteShared::NotesNetworkReceiver *recv = new NoteShared::NotesNetworkReceiver( s );
-        connect( recv, SIGNAL(noteReceived(QString,QString)), SLOT(slotNewNote(QString,QString)) );
+        connect( recv, SIGNAL(sigNoteReceived(QString,QString)), SLOT(slotNewNote(QString,QString)) );
     }
 }
Comment 1 Silvan Calarco 2014-09-19 15:41:28 UTC
Created attachment 88753 [details]
The patch mentioned in previous commit
Comment 2 Laurent Montel 2014-09-19 16:37:31 UTC
Already fixed in 4.14.1
But thanks :)