Summary: | digiKam crashes when trying to stop find duplicates | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Mark Fraser <mfraz74+kde> |
Component: | Searches-Similarity | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | caulier.gilles, nucleo, rdieter |
Priority: | NOR | ||
Version: | 4.3.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.4.0 | |
Attachments: | digiKam backtrace |
Description
Mark Fraser
2014-09-19 12:44:41 UTC
Created attachment 88751 [details]
digiKam backtrace
Already fixed with this commit : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/30e65a812f5aff808173dad52100c93dcc24b988 Gilles Caulier (In reply to Gilles Caulier from comment #2) > Already fixed with this commit : > > https://projects.kde.org/projects/extragear/graphics/digikam/repository/ > revisions/30e65a812f5aff808173dad52100c93dcc24b988 > > Gilles Caulier patching file utilities/maintenance/imageinfojob.cpp Reversed (or previously applied) patch detected! Assume -R? [n] Looks like this commit alreafy applied in digiKam 4.3.0 sources, so if crash fixed then maybe in other commit? Nucleao, Look the date of commit : ID: 30e65a812f5aff808173dad52100c93dcc24b988 Added by Teemu Rytilahti 4 days ago Don't crash if there's an error during the job 4.3.0 tarball have been created well before... Gilles Caulier Here commit: --- a/utilities/maintenance/imageinfojob.cpp +++ b/utilities/maintenance/imageinfojob.cpp @@ -110,8 +110,6 @@ bool ImageInfoJob::isRunning() const void ImageInfoJob::slotResult(KJob* job) { - d->job = 0; - if (job->error()) { kWarning() << "Failed to list url: " << job->errorString(); @@ -121,6 +119,8 @@ void ImageInfoJob::slotResult(KJob* job) DigikamApp::instance(), DigikamApp::instance()->windowTitle()); } + d->job = 0; + emit signalCompleted(); } And here actual code from 4.3.0 tarball: void ImageInfoJob::slotResult(KJob* job) { if (job->error()) { kWarning() << "Failed to list url: " << job->errorString(); // Pop-up a message about the error. DNotificationWrapper(QString(), d->job->errorString(), DigikamApp::instance(), DigikamApp::instance()->windowTitle()); return; } d->job = 0; emit signalCompleted(); } So patch already applied in 4.3.0 sources. Ahh... This one is not include to 4.3.0 i think : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/d523a9768ab8276860c76e02b9d9b598a3d607f9 Gilles Caulier (In reply to Gilles Caulier from comment #6) > Ahh... > > This one is not include to 4.3.0 i think : > > https://projects.kde.org/projects/extragear/graphics/digikam/repository/ > revisions/d523a9768ab8276860c76e02b9d9b598a3d607f9 This commit fixes crash in 4.3.0. Thanks. |