| Summary: | r-backend tries to start $EDITOR on fix(), this is unusable for EDITOR=nano and vim | ||
|---|---|---|---|
| Product: | [Applications] cantor | Reporter: | hoea |
| Component: | r-backend | Assignee: | Alexander Rieder <alexanderrieder> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | warquark |
| Priority: | NOR | ||
| Version First Reported In: | 0.5 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/cantor/b2ba96b6425a2a9ed84ee48dd938bc35af0a0c41 | Version Fixed/Implemented In: | 18.04.1 |
| Sentry Crash Report: | |||
|
Description
hoea
2014-09-16 19:22:36 UTC
Git commit 3b4363d41cbeb993c6d5975d5cd5c93669fdcc66 by Nikita Sirgienko. Committed on 08/05/2018 at 20:29. Pushed by sirgienko into branch 'master'. Add GUI editor for R backend Summary: Before, if we have called `fix` function and our `EDITOR` was console editor, we have had problems: editor starts as child process and we never can end it. This commit fix it, by building cantor script editor as executable file and setting the editor as editor for R. FIXED-IN: 18.04.1 Test Plan: 1) Open terminal, set console editor as EDITOR (`export EDITOR=/bin/nano`, for example) and start cantor in this terminal session. 2) Start R backend, create array (`a <- c(1,2,3)`, for example) 3) Call `fix(a)` and check, that you have the problem 4) Apply the patch 5) Do 1)-2) again and check, that you start edit `a` in kate Reviewers: #cantor, asemke Reviewed By: #cantor, asemke Subscribers: #cantor, #kde_edu Tags: #kde_edu, #cantor Differential Revision: https://phabricator.kde.org/D12721 M +2 -1 src/CMakeLists.txt M +3 -0 src/backends/R/rserver/rserver.cpp M +1 -1 src/cantor_part.cpp A +10 -0 src/scripteditor/CMakeLists.txt A +44 -0 src/scripteditor/main.cpp [License: GPL (v2+)] R +4 -0 src/scripteditor/scripteditorwidget.cpp [from: src/scripteditorwidget.cpp - 098% similarity] R +1 -0 src/scripteditor/scripteditorwidget.h [from: src/scripteditorwidget.h - 098% similarity] https://commits.kde.org/cantor/3b4363d41cbeb993c6d5975d5cd5c93669fdcc66 Git commit b2ba96b6425a2a9ed84ee48dd938bc35af0a0c41 by Alexander Semke, on behalf of Nikita Sirgienko. Committed on 03/06/2018 at 08:23. Pushed by asemke into branch 'Applications/18.04'. Add GUI editor for R backend Summary: Before, if we have called `fix` function and our `EDITOR` was console editor, we have had problems: editor starts as child process and we never can end it. This commit fix it, by building cantor script editor as executable file and setting the editor as editor for R. FIXED-IN: 18.04.1 Test Plan: 1) Open terminal, set console editor as EDITOR (`export EDITOR=/bin/nano`, for example) and start cantor in this terminal session. 2) Start R backend, create array (`a <- c(1,2,3)`, for example) 3) Call `fix(a)` and check, that you have the problem 4) Apply the patch 5) Do 1)-2) again and check, that you start edit `a` in kate Reviewers: #cantor, asemke Reviewed By: #cantor, asemke Subscribers: #cantor, #kde_edu Tags: #kde_edu, #cantor Differential Revision: https://phabricator.kde.org/D12721 M +2 -1 src/CMakeLists.txt M +3 -0 src/backends/R/rserver/rserver.cpp M +1 -1 src/cantor_part.cpp A +10 -0 src/scripteditor/CMakeLists.txt A +44 -0 src/scripteditor/main.cpp [License: GPL (v2+)] R +4 -0 src/scripteditor/scripteditorwidget.cpp [from: src/scripteditorwidget.cpp - 098% similarity] R +1 -0 src/scripteditor/scripteditorwidget.h [from: src/scripteditorwidget.h - 098% similarity] https://commits.kde.org/cantor/b2ba96b6425a2a9ed84ee48dd938bc35af0a0c41 |