| Summary: | Allow the usage of arrows to move in the photo sequence when in preview [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Luca Carlon <carlon.luca> |
| Component: | Preview-Image | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, tpr |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/fca9b840bfa68aedff7531135c39812ab98faa88 | Version Fixed In: | 4.6.0 |
| Attachments: |
Allows the usage of arrows in preview.
Allows the usage of arrows in preview. Allows the usage of arrows in preview. |
||
|
Description
Luca Carlon
2014-09-13 22:01:08 UTC
Created attachment 88696 [details]
Allows the usage of arrows in preview.
Created attachment 89698 [details]
Allows the usage of arrows in preview.
Inverted params in the macro as requested.
Gilles, what do you think? For me it looks good. The feature is fine for me. Patch include a macro which must be factored somewhere in a common place (as core/app/utils/global.h) and used where we can to reduce duplicate code. Gilles Created attachment 89701 [details]
Allows the usage of arrows in preview.
Moved to globals.h as requested to try to reuse the code.
Git commit fca9b840bfa68aedff7531135c39812ab98faa88 by Gilles Caulier. Committed on 26/11/2014 at 12:49. Pushed by cgilles into branch 'master'. apply patch #89701 from Lucas Carlon about to manage arrow keys to navigate between items as with PAGE_UP and PAGE_DOWN This affect ImageEditor, LightTable, AlbumGUI Preview Mode, and ImportGUI Preview Mode. FIXED-IN: 4.6.0 M +2 -1 NEWS M +27 -6 app/utils/globals.h M +7 -9 app/views/digikamview.cpp M +10 -5 utilities/imageeditor/editor/editorwindow.cpp M +10 -0 utilities/imageeditor/editor/editorwindow_p.h M +8 -13 utilities/importui/views/importview.cpp M +3 -1 utilities/lighttable/lighttablewindow.cpp M +13 -0 utilities/lighttable/lighttablewindow_p.h http://commits.kde.org/digikam/fca9b840bfa68aedff7531135c39812ab98faa88 |