Bug 339008

Looking at the backtrace, there are two threads that mention ICCPreviewWidget. Are UI classes used in multiple threads? Maybe because of external libraries needing nested event loops?

yes, digiKam use multithreading everywhere.

When i said everywhere, digiKam cannot be started when relevant shared lib for multithreading are not installed (typically QThread)

So, it's not a threads problem. Sound like an unsupported icc profile embeded in image, which cannot be managed by lcms shared lib.

Gilles Caulier

http://qt-project.org/doc/qt-4.8/thread-basics.html states:

"As mentioned, each program has one thread when it is started. This thread is called the "main thread" (also known as the "GUI thread" in Qt applications). The Qt GUI must run in this thread. All widgets and several related classes, for example QPixmap, don't work in secondary threads."

So while it is nice that digiKam uses multiple threads, it cannot use ICCPreviewWidget outside of the main UI thread.

I know all of this (:=))) 

But i'm sure that iccpreview widget is not used outside main thread.

Note : About QPixmap, it's only true under X11 based env, because X11 is not re-entrant...

Gilles

digiKam 4.5.0 have been released.

Crash still reproducible with this release ?

Gilles Caulier

With 4.5.0, you can still 
- Start Digikam
- Import -> Add images...
- Select folder
- ... See The KDE crash handler

I attached the latest Crash log

Created attachment 89914 [details]
Crash log

Crash log created by the KDE crash handler, when Digikam crashes while it should import images.

Problem still reproducible with last stable digiKam 4.8.0 ?

Gilles Caulier

Can't check:
The most recent Digikam-Installer package on http://download.kde.org/stable/digikam/ is 4.5.0

Maybe, you can forward a request to the one who generates the windows installer to be so kind to let it run? (If it'd be that easy...)

Peter,

digiKam 4.7.0 for Windows is available :

http://download.kde.org/stable/digikam/digiKam-installer-4.7.0-1-win32.exe.mirrorlist

Please test and report.

Thanks in advance

Gilles Caulier

Hi Gilles,

thank you for providing the installer!
I'll try it this evening and report the results.

Peter

Hi Gilles,

on my Win8.1-System, the Digikam 4.7.0 you provided is still crashing on import. 
I was able to do the following:
Import-> Add images -> [walk to import folder]-> select folder -> crash

I attached the crash log.

cu
Peter

Created attachment 91757 [details]
Crash log

Not sure if helpful to say "me too", but this has been a bug in the last few 4.x versions for me as well on Windows 8.1. It is still happening in 4.9.0. I'll try attach a backtrace to this ticket.

Created attachment 91937 [details]
Backtrace for crash when clicking Import>Card Readers>(Any USB stick)

Backtrace for crash when clicking Import>Card Readers>(Any USB stick)

*** Bug 342673 has been marked as a duplicate of this bug. ***

digikamlib.dll!Digikam::PreviewSettings::PreviewSettings() [[unknown] @ -1] at 0x7756790c
kdeui.dll!QList<KSortableItem<QString,int> >::value() [[unknown] @ -1] at 0xf488c10
QtGui4.dll!QFont::operator==() [[unknown] @ -1] at 0x64d9ac8e
QtGui4.dll!QWidgetPrivate::resolveFont() [[unknown] @ -1] at 0x64c3ecae
QtGui4.dll!QWidgetPrivate::updateFont() [[unknown] @ -1] at 0x64c3ef37
QtGui4.dll!QWidgetPrivate::resolveFont() [[unknown] @ -1] at 0x64c3ecae
QtGui4.dll!QWidget::event() [[unknown] @ -1] at 0x64c46036
QtGui4.dll!QAbstractScrollArea::event() [[unknown] @ -1] at 0x64f9e318
QtGui4.dll!QAbstractItemView::event() [[unknown] @ -1] at 0x65016ab5
QtGui4.dll!QApplicationPrivate::notify_helper() [[unknown] @ -1] at 0x64c004cd
kdeui.dll!QList<KSortableItem<QString,int> >::value() [[unknown] @ -1] at 0xf488c10
QtCore4.dll!QCoreApplication::sendEvent() [[unknown] @ -1] at 0x66f63cf6
QtGui4.dll!QWidget::raise() [[unknown] @ -1] at 0x64c4a878

Sound like the problem is in PreviewSettings constructor.

Git commit 302f92bd9afb7c7b54cedf89d3bc2166a57dfbce by Maik Qualmann.
Committed on 08/04/2015 at 17:57.
Pushed by mqualmann into branch 'master'.

blocking ImportStackedView::syncSelection to also thumbBar->setModelsFiltered is set

M  +2    -0    utilities/importui/views/importstackedview.cpp

http://commits.kde.org/digikam/302f92bd9afb7c7b54cedf89d3bc2166a57dfbce

When the Import window open there was always this message in the console:

digikam(9655)/digikam (core) Digikam::ImportStackedView::syncSelection: one or both of the models are null?! from: Digikam::ImportIconView(0x6a6d420) to: Digikam::ImportThumbnailBar(0x6c0c340) 

I fixed this issue, the crash under Windows it will probably not fix.

Maik

This error ("Import-> Add images -> [walk to import folder]-> select folder -> crash") consistently occurs for me using digikam 4.9.0 on OSX 10.10.3, with MacPorts 2.3.3.

*** Bug 340990 has been marked as a duplicate of this bug. ***

meanwhile, 4.10.0 is available. I installed it and the error (chrash while rebuilding fingerprints) is still there.
Thanx for the current windows versions.

Git commit ad8538938371ec4152450c661b1857f8441e3af8 by Maik Qualmann.
Committed on 19/06/2015 at 21:01.
Pushed by mqualmann into branch 'master'.

fixes the model initialisation from the icon view and thumb bar of the import window
Related: bug 349280
FIXED-IN: 4.12.0

M  +3    -1    NEWS
M  +1    -7    utilities/importui/main/importui.cpp
M  +7    -3    utilities/importui/views/importiconview.cpp
M  +0    -2    utilities/importui/views/importiconview.h
M  +11   -20   utilities/importui/views/importstackedview.cpp
M  +0    -1    utilities/importui/views/importstackedview.h
M  +3    -12   utilities/importui/views/importview.cpp
M  +1    -1    utilities/importui/views/importview.h

http://commits.kde.org/digikam/ad8538938371ec4152450c661b1857f8441e3af8

Git commit 0d4dca4094dab6930c66dc22adc6b2d31bcbe038 by Gilles Caulier.
Committed on 20/06/2015 at 15:52.
Pushed by cgilles into branch 'frameworks'.

backport commit #ad8538938371ec4152450c661b1857f8441e3af8 from git/master to frameworks branch
Related: bug 349280

M  +1    -7    utilities/importui/main/importui.cpp
M  +7    -3    utilities/importui/views/importiconview.cpp
M  +0    -2    utilities/importui/views/importiconview.h
M  +11   -18   utilities/importui/views/importstackedview.cpp
M  +0    -1    utilities/importui/views/importstackedview.h
M  +8    -14   utilities/importui/views/importview.cpp
M  +3    -2    utilities/importui/views/importview.h

http://commits.kde.org/digikam/0d4dca4094dab6930c66dc22adc6b2d31bcbe038

the crash while rebuilding fingerprints (Bug 342673), still occurs in 4.12.0