Summary: | Umbrello crashes when adding name to line between normal and branch widget | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Øystein S. Haaland <oystein.s.haaland> |
Component: | general | Assignee: | Oliver Kellogg <okellogg> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | okellogg |
Priority: | NOR | ||
Version: | Git | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/umbrello/2537f92573a0c85dea38a588152a5cff6cba33b7 | Version Fixed In: | 4.14.1 |
Attachments: | Drkonqi report |
Description
Øystein S. Haaland
2014-09-10 14:39:49 UTC
Created attachment 88642 [details]
Drkonqi report
Drkonki didn't manage to send the information, saying i have to login in first even though i logged in in an earlier step.
Confirm on git master. Analysis: AssociationGeneralPage::updateObject() accesses m_pStereoChkB->isChecked() without prior check of m_pStereoChkB against NULL. However, m_pStereoChkB is only non NULL for associations which have an underlying UML object, see umbrello/dialogs/pages/associationgeneralpage.cpp:113 ff.: if (umlAssoc) { // stereotype checkbox m_pStereoChkB = new QCheckBox(i18n("Stereotype"), nameAndTypeGB); [...] } Git commit 292b7446548e67522ef7066b88f2c3b9ecfff7ac by Oliver Kellogg. Committed on 10/09/2014 at 19:18. Pushed by okellogg into branch 'master'. Fix for crash setting name on diagram-only association via Association Properties page according to analysis in comment #2: umbrello/dialogs/pages/associationgeneralpage.cpp - In function updateObject() add test of m_pStereoChkB against NULL before dereferencing. M +1 -1 umbrello/dialogs/pages/associationgeneralpage.cpp http://commits.kde.org/umbrello/292b7446548e67522ef7066b88f2c3b9ecfff7ac Git commit 2537f92573a0c85dea38a588152a5cff6cba33b7 by Oliver Kellogg. Committed on 10/09/2014 at 20:10. Pushed by okellogg into branch 'KDE/4.14'. Merge master@286493f into KDE/4.14 Related: bug 338983 FIXED-IN:4.14.1 FIXED-IN:4.14.1 http://commits.kde.org/umbrello/2537f92573a0c85dea38a588152a5cff6cba33b7 I can confirm that it works. Thanks a lot for the quick fix! |