| Summary: | Choqok only lists 20 friends | ||
|---|---|---|---|
| Product: | [Applications] choqok | Reporter: | Ian Schwarz <m_105> |
| Component: | Assignee: | Mehrdad Momeny <mehrdad.momeny> | |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | daniel.kreuter85, m_105, scarpino |
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/choqok/bffb944478e0c7b28923c72dc5d59f37ee13660e | Version Fixed In: | 1.5 |
| Sentry Crash Report: | |||
| Attachments: |
Request all friends using cursor parameter
updated patch updated patch, again |
||
Adding a "count" parameter of 200 would further reduce the number of requests per update so we don't hit the rate limit as quickly. Hi Ian, setting count to the maximum possible value is always the best way I think (You have only a limited number of requests per hour on Twitter because of performance reasons). Cheers Daniel Oh and btw, can you please upload your patch to git.reviewboard.kde.org (group choqok) Cheers Daniel Created attachment 88646 [details]
updated patch
Hey Daniel,
I would, but it's not a git diff and I have no idea how to create one.
I updated my patch to include a larger count.
Created attachment 88647 [details]
updated patch, again
Not text/plain.
(In reply to Ian Schwarz from comment #4) > Created attachment 88646 [details] > updated patch > > Hey Daniel, > > I would, but it's not a git diff and I have no idea how to create one. > I updated my patch to include a larger count. $ git diff > patch.diff http://git-scm.com/docs/git-diff (In reply to Mehrdad Momeny from comment #6) > $ git diff > patch.diff > http://git-scm.com/docs/git-diff Huh, that's much easier than what I was doing. I had no idea, thank you very much. Anyway, I uploaded the patch to the reviewboard. Git commit bffb944478e0c7b28923c72dc5d59f37ee13660e by Mehrdad Momeny. Committed on 12/09/2014 at 16:24. Pushed by momeny into branch 'master'. REVIEW:120143 Loop for all friends and list them in Choqok's PM dialog and save. Based on a patch from Ian Schwarz. M +1 -1 helperlibs/twitterapihelper/twitterapidmessagedialog.cpp M +37 -21 helperlibs/twitterapihelper/twitterapimicroblog.cpp http://commits.kde.org/choqok/bffb944478e0c7b28923c72dc5d59f37ee13660e |
Created attachment 88640 [details] Request all friends using cursor parameter Choqok lists a maximum of 20 friends right now, which is the default friend count returned per request (200 maximum). Attached patch uses the Twitter API's "cursor" parameter to request all friends.