Bug 338883

Summary: Kmenuedit's icons don't follow the "small icons" size
Product: [Applications] kmenuedit Reporter: Janet <bugzilla>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: egorov, simonandric5
Priority: NOR Keywords: junior-jobs
Version: unspecified   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
Latest Commit: http://commits.kde.org/kmenuedit/5620d705708aa6bad56739a0846594e50edcfea9 Version Fixed In: 4.11.13

Description Janet 2014-09-07 18:58:08 UTC 
The icons in kmenuedit's tree are in a tiny fixed icon size, I guess 16. The icon size does not respect the "small icons" size from systemsettings. The reason I have set the "small icons" to size 32 is that I cannot recognize and reliably hit too small icons and I presume I am not the only one. To make the gui usable for everyone, even the not so good eyed people, it would be nice if the tree icons would follow the "small icons" settings so everybody gets the icon size needed or preferred.

For me this is a gui/usability bug but I guess I'm on the save side with a wishlist entry ;).

Reproducible: Always

Steps to Reproduce:
1. Set the "small icons" to e.g. 32 via systemsettings.
2. Open kmenuedit: The tree icons remain small and are not displayed in size 32.
3.


Expected Results:  
All small icons should follow the general "small icons" size.

At the moment I am using kmenuedit 0.9 with KDE SC 4.14 in Debian Sid.
Comment 1 Christoph Feck 2014-09-07 23:19:09 UTC 
I love the comment in the code.
Comment 2 Boris Egorov 2014-09-09 16:59:15 UTC 
Looks simple enough: we need to remove code which resize icon to 20x20 pixels. The question is why such restriction was done. You can find it in commit 56584682d, there was created appIcon() function. Seems like removing this code don't break anything.
The only problem I see is in TreeView::startDrag() method. You can see hardcoded icon size here. Is it possible to extract width and height from KIconLoader::Small group?
Comment 3 Albert Astals Cid 2014-09-28 16:03:47 UTC 
Git commit 27b8cc27af1d07d5e1023e2b3e18fff9bcf4e6f6 by Albert Astals Cid, on behalf of Boris Egorov.
Committed on 28/09/2014 at 16:02.
Pushed by aacid into branch 'KDE/4.11'.

kmenuedit: do not resize app icons

We want to use icons size taken from KIconLoader::Small group and not
resize it to 20x20 pixels.

Use KIconLoader::currentSize() to determine icon size of dragged item.
REVIEW: 120120
FIXED-IN: 4.11.13

M  +2    -8    kmenuedit/treeview.cpp

http://commits.kde.org/kde-workspace/27b8cc27af1d07d5e1023e2b3e18fff9bcf4e6f6
Comment 4 Albert Astals Cid 2014-09-28 16:05:45 UTC 
Git commit 5620d705708aa6bad56739a0846594e50edcfea9 by Albert Astals Cid, on behalf of Boris Egorov.
Committed on 28/09/2014 at 16:04.
Pushed by aacid into branch 'Plasma/5.1'.

kmenuedit: do not resize app icons

We want to use icons size taken from KIconLoader::Small group and not
resize it to 20x20 pixels.

Use KIconLoader::currentSize() to determine icon size of dragged item.

Acked by Christoph Feck
REVIEW: 120120

M  +2    -8    treeview.cpp

http://commits.kde.org/kmenuedit/5620d705708aa6bad56739a0846594e50edcfea9