| Summary: | Context menu and Del key doesn't work when Dolphin restores session with split view enabled | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | karaluh <karaluh> |
| Component: | split view | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | emmanuelpescosta099 |
| Priority: | NOR | ||
| Version: | 4.14.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/13efd5950b4c6b017514325a0ce7bc13d9895c59 | Version Fixed In: | 4.14.1 |
| Sentry Crash Report: | |||
|
Description
karaluh
2014-08-25 15:10:06 UTC
Thanks, I can reproduce this bug. Only the stable branch 4.14 is affected by this bug. Review-Request: https://git.reviewboard.kde.org/r/119961/ Git commit 13efd5950b4c6b017514325a0ce7bc13d9895c59 by Emmanuel Pescosta. Committed on 27/08/2014 at 20:40. Pushed by emmanuelp into branch 'KDE/4.14'. Only keep the active view container connected with the main window, all inactive view containers are disconnected. Changing the connections is done whenever the active view has been changed, so we can always guarantee that the active view is connected. The problem with restoring saved sessions is, that we create a new view container in DolphinTabPage::restoreState() when split view was used in the previous session, but this view container isn't connected to the main window slots because DolphinMainWindow::connectViewSignals() is not called for this container. This leads to these strange problems: no context menu, ... REVIEW: 119961 FIXED-IN: 4.14.1 M +10 -12 dolphin/src/dolphinmainwindow.cpp http://commits.kde.org/kde-baseapps/13efd5950b4c6b017514325a0ce7bc13d9895c59 |