| Summary: | Toolbox not at feature parity with containment context menu (but fed by the same actions) | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Bhushan Shah <bshah> |
| Component: | general | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | bshah, justin.zobel, kde, notmart |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Bhushan Shah
2014-08-16 16:19:05 UTC
perhaps regression is not correct word.. but this is annoying for sure. This isn't really a bug or regression in Folder View; it's a regression in the platform. Plasma 4 allowed for the context menu and toolbox actions to be different as a by-product of how the API was patterned, Plasma 5 doesn't. There's two options: a) Enhance the API. The downside of this is that it ends up baking certain assumptions about the UI into the API, i.e. the notion that there's a context menu and a toolbox. b) Enhance the default toolbox implementation. For example, it could be made smart enough to skip separators, or render them differently. How to handle menu actions (i.e. actions with a submenu) is another problem. I'm predicting Marco will favor some form of 'b', so I'm reassigning this to plasmashell::general in lieu of a (non-existing) Toolbox component and CC'ing him. On Sun, Aug 17, 2014 at 11:25 AM, Eike Hein <hein@kde.org> wrote: > This isn't really a bug or regression in Folder View; it's a regression in the > platform. Plasma 4 allowed for the context menu and toolbox actions to be > different as a by-product of how the API was patterned, Plasma 5 doesn't. Yup, sorry bug / regression was really wrong word.. Git commit 0f0006e4a93773429c0220b26fe5c65dfcb85071 by Marco Martin. Committed on 21/08/2014 at 19:19. Pushed by mart into branch 'master'. remove manus from plasmoid.actions not really solution-solution, but not really other ways due to QAction api so will stay this way for a long time M +5 -1 src/scriptengines/qml/plasmoid/containmentinterface.cpp http://commits.kde.org/plasma-framework/0f0006e4a93773429c0220b26fe5c65dfcb85071 David, I put this on general for a reason because it's not Folder-specific, why did you move it again? because the title starts with "Folder containment" and I didn't read all the comments/history. If it's a more generic bug the title needs changing. Can someone please confirm if this is still an issue, thank you. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |