Bug 338224

Summary:	Inconsistent "Zoom to 100%" shortcut behavior between Preview Mode and Image Editor
Product:	[Applications] digikam	Reporter:	DrSlony <bugs>
Component:	Usability-Keyboard	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs, caulier.gilles, metzpinguin
Priority:	NOR
Version:	4.2.0
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/028793b9e3a830a51ed05fc738a5db8825941652	Version Fixed In:	4.6.0
Sentry Crash Report:
Attachments:	zoomto100.patch

Description DrSlony 2014-08-12 17:55:30 UTC

In digiKam the Zoom to 100% shortcut, which I set to *, zooms the image to 100%, and if I click * again, it fits it to window again.
In showFoto I set the same shortcuts, but there it only zooms to 100%. If I click it again, nothing happens, it does not toggle back and forth between 100% and fit-to-window as digiKam does.

Comment 1 DrSlony 2014-09-15 17:07:38 UTC

This applies to the Light Table too.

Comment 2 Maik Qualmann 2014-12-08 21:20:22 UTC

Gilles,

i want to fix this bug. What do you think, how the behavior of "Fit to Window" and should be "Zoom to 100%"?

Preview from Album:
Fit to Window -> only fit to window
Zoom to 100%  -> toggled 100% and fit to Window

Image Editor:
Fit to Window -> toggled fit to Window and last zoom
Zoom to 100%  -> only zoom to 100%

Preview from LightTable:
Fit to Window -> only fit to window
Zoom to 100%  -> only zoom to 100%

Preview from Import:
Fit to Window -> only fit to window
Zoom to 100%  -> toggled 100% and fit to Window

I would be for the behavior of preview from Album and Import.

Comment 3 DrSlony 2014-12-08 22:53:48 UTC

They should toggle back and forth. It is of no benefit if they don't.

Comment 4 caulier.gilles 2014-12-09 08:33:36 UTC

 I'am surprised about the différence between preview, LT, and Editor.
In all case, behavior must be the same everywhere.
The good behavior is preview mode from album view and import tool.

Gilles Caulier

Comment 5 Maik Qualmann 2014-12-10 17:29:16 UTC

Created attachment 89909 [details]
zoomto100.patch

This patch is present everywhere the same behavior of Zoom to 100%.
First applies Zoom to 100% then fit to window.

Comment 6 caulier.gilles 2014-12-10 17:45:40 UTC

Git commit 028793b9e3a830a51ed05fc738a5db8825941652 by Gilles Caulier.
Committed on 10/12/2014 at 17:44.
Pushed by cgilles into branch 'master'.

Apply patch #89909 from Maik Qualmann about to fix zoom to 100% behavior to have same rules everywhere (IE, LY, Preview)
FIXED-IN: 4.6.0

M  +2    -1    NEWS
M  +1    -1    libs/widgets/graphicsview/previewlayout.cpp
M  +2    -2    utilities/imageeditor/editor/editorstackview.cpp
M  +2    -2    utilities/lighttable/lighttableview.cpp

http://commits.kde.org/digikam/028793b9e3a830a51ed05fc738a5db8825941652