| Summary: | Text for RandomBiasFactory says 'random tracks' but the text once added is 'random songs' | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | robert marshall <robert> |
| Component: | Playlists/Dynamic Playlists | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ralf-engels |
| Priority: | NOR | ||
| Version: | 2.8-git | ||
| Target Milestone: | 2.9 | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/0f0e494301dcb0c25a232579cf291e8846fa9937 | Version Fixed In: | 2.9 |
| Sentry Crash Report: | |||
Yes, definitely. Could you please add the patch as an attachment, or even better, submit it to http://reviewboard.kde.org and subscribe the group Amarok? You will need an account on http://identity.kde.org for this, if you do not have one already. It's on the review board (I hope!) https://git.reviewboard.kde.org/r/119429/ The diffs were done with C-x v = in emacs if that isn't the correct set of diff flags let me know ... I've got a couple of other local changes to amarok I mean to submit via the reviewboard once I've worked out how to do it! Looks perfectly fine. Do you have commit rights? No - see Matěj's comments in the review board thread. Git commit 0f0e494301dcb0c25a232579cf291e8846fa9937 by Mark Kretschmann, on behalf of Robert Marshall. Committed on 25/07/2014 at 03:47. Pushed by markey into branch 'master'. Display 'random tracks' rather than 'random songs' in dynamic mode playlist. [Bug 337725] Text for RandomBiasFactory says 'random tracks' but the text once added is 'random songs' REVIEW: 119429 FIXED-IN: 2.9 M +1 -1 src/dynamic/Bias.cpp M +1 -1 src/dynamic/biases/SearchQueryBias.cpp http://commits.kde.org/amarok/0f0e494301dcb0c25a232579cf291e8846fa9937 |
The texts need to be consistent - and elsewhere amarok uses tracks. I suggest these changes: diff --git a/src/dynamic/Bias.cpp b/src/dynamic/Bias.cpp index d0aab75..03caf48 100644 --- a/src/dynamic/Bias.cpp +++ b/src/dynamic/Bias.cpp @@ -117,7 +117,7 @@ Dynamic::RandomBias::name() const QString Dynamic::RandomBias::toString() const { - return i18nc("Random bias representation", "Random songs"); + return i18nc("Random bias representation", "Random tracks"); } QWidget* diff --git a/src/dynamic/biases/SearchQueryBias.cpp b/src/dynamic/biases/SearchQueryBias.cpp index cfe4b01..9c5f607 100644 --- a/src/dynamic/biases/SearchQueryBias.cpp +++ b/src/dynamic/biases/SearchQueryBias.cpp @@ -112,7 +112,7 @@ Dynamic::SearchQueryBias::toString() const { if( m_filter.isEmpty() ) return i18nc("Random bias representation", - "Random songs"); + "Random tracks"); else return i18nc("SearchQuery bias representation", "Search for: %1", m_filter );